68
votes

I've got the "Object is possibly null" error many times and usually I use a safety "if statement" in case it returns null.

I've got the following function:

const ModalOverlay = (props: any[]) => {
  const overlayEl = useRef(null);
    useEffect(() => {
    overlayEl.current.focus();
    });
    return <div {...props} ref={overlayEl} />;
  }

But overlayEl.current gets the error "Object is not defined". So I've tried:

if (!overlayEl) {
    return null
  } else {
    useEffect(() => {
    overlayEl.current.focus();
    });
    return <div {...props} ref={overlayEl} />;
  }

Which didn't work. I've tried also:

overlay && overlayEl.current.focus();

Any hints would be highly appreciated! Thanks

9

9 Answers

132
votes

When you declare const overlayEl = useRef(null); Makes the type it comes out as is null because that's the best possible inference it can offer with that much information, give typescript more information and it will work as intended.

Try....

 const overlayEl = useRef<HTMLDivElement>(null);

Alternatively some syntax sugar for if you don't care for when its undefined is to do something like this.

const overlayEl = useRef(document.createElement("div"))

using the above syntax all common DOM methods just return defaults such as "0" i.e overlayEl.offsetWidth, getBoundingClientRect etc.

Usage:

if(overlayEl.current) {
    // will be type HTMLDivElement NOT HTMLDivElement | null
    const whattype = overlayEl.current; 
}

The way this works is typescripts static analysis is smart enough to figure out that if check "guards" against null, and therefore it will remove that as a possible type from the union of null | HTMLDivElement within those brackets.

19
votes
const overlayEl = useRef() as MutableRefObject<HTMLDivElement>;

It will cast overlayEl to an initiated MutableRefObject that is the returning value of useRef:

function useRef<T = undefined>(): MutableRefObject<T | undefined>;

Yet in this case, the compiler will always think that overlayEl has a value.

12
votes

Add a type to the ref as mentioned by @Shanon Jackson:

const linkRef = useRef<HTMLLinkElement>(null);

And then, make sure you check for null value before using current:

if (linkRef.current !== null) {
  linkRef.current.focus();
}

This will satisfy Typescript. Whereas either by itself wouldn't.

Using any or casting in order to "trick" the compiler defeats the purpose of using Typescript, don't do that.

5
votes

If you really know that in executing time you dont have a error here then just put :

 (overlayEl as any).current 

If not, better use:

    if (typeof overlayEl !== 'undefined' &&
      typeof overlayEl.current !== 'undefined' &&
      overlayEl.current === null) {          
      return;
    }

    // Or

    try {
      // you code here ...
      // This is fine way to check by order -> parent.parent.FinalInstance
      // Also try & catch will handle all bad situation about current error
      overlay &&  overlayEl.current && overlayEl.current.focus();

    } catch(e){
       console.log("Real null >> ", e);     
    }

  // Suggest if i am wrong in syntax somewhere ,this is fast answer ;)
4
votes

You can also use optional chaining which is introduced in ES2020 instead of "if" statement for cleaner code

const myRef = useRef<HTMLLinkElement>(null);

myRef.current?.focus();

You can check its browser support at caniuse.

2
votes

If you want to "pass/skip" then this will do it const overlayEl: any = useRef(null);

0
votes

if you want to give no chance to typescript use this :

const iframe = useRef<HTMLIFrameElement | null>(null);

     if (
   typeof iframe !== "undefined" &&
   typeof iframe.current !== "undefined" &&
   iframe.current !== null
 ) {
   iframe?.current?.contentWindow='';
   );
 }
0
votes

Sometimes we use Ref not only to hold an element but a value like data. somehow when I check if(something.current) return something.current not working even if i add && something.current!=null so i found that:

something.current! which says to typescript i know there is a value and bypass this issue.

0
votes

I think this is more succinct than the other answers here:

const ModalOverlay = (props: any[]) => {
  const overlayEl = useRef<HTMLDivElement>(null);
  useEffect(() => {
    overlayEl.current!.focus();
  });
  return <div {...props} ref={overlayEl} />;
}

You specify the type of the reference, and you state you know it's not null.