PHP Image Upload Strange Issue

Question

<?
if(isset($_POST['submit'])){

$url = 'http://www.connectedcampus.org/ckeditor/images/uploads/';

if (($_FILES['upload'] == "none") OR (empty($_FILES['upload']['name'])) )
{
   $message = "No file uploaded.";
}
else if ($_FILES['upload']["size"] == 0)
{
   $message = "The file is of zero length.";
}
else if (($_FILES['upload']["type"] != "image/pjpeg") AND ($_FILES['upload']["type"] != "image/jpeg") AND ($_FILES['upload']["type"] != "image/png"))
{
   $message = "The image must be in either JPG or PNG format. Please upload a JPG or PNG instead.";
}
else if($_FILES["file"]["size"] > 1000000){
    $message = "File size too big!";
}
else if(file_exists($url.$_FILES["file"]["name"]))
  {
  $message=$_FILES["file"]["name"] . " already exists. ";
  }
else if (!is_uploaded_file($_FILES['upload']["tmp_name"]))
{
   $message = "Invalid File!";
}
else {
  $message = "success!";
  $move = move_uploaded_file($_FILES['upload']['tmp_name'], $url.$_FILES['upload']['name']);
  echo $_FILES['upload']['tmp_name']."<br>";
  echo $url.$_FILES['upload']['name'];
  if(!$move)
  {
     $message = "Error moving uploaded file.";
  }
  $url = $url.$_FILES['upload']['name'];
}
 echo $message;
 </script>";
 }
 ?>

This prints "Error moving uploaded file" Which means move_uploaded_file($_FILES['upload']['tmp_name'], $url.$_FILES['upload']['name']) returns false. But I am 500% sure that i have created http://www.connectedcampus.org/ckeditor/images/uploads/ folder properly.... then why is there an error?

Ok, now changed to:

$url = 'bloguploads/';

    if (($_FILES['upload'] == "none") OR (empty($_FILES['upload']['name'])) )
    {
       $message = "No file uploaded.";
    }
    else if ($_FILES['upload']["size"] == 0)
    {
       $message = "The file is of zero length.";
    }
    else if (($_FILES['upload']["type"] != "image/pjpeg") AND ($_FILES['upload']["type"] != "image/jpeg") AND ($_FILES['upload']["type"] != "image/png"))
    {
       $message = "The image must be in either JPG or PNG format. Please upload a JPG or PNG instead.";
    }
else if($_FILES["file"]["size"] > 1000000){
       $message = "File size too big!";
}
else if(file_exists($url.$_FILES["file"]["name"]))
    {
       $message=$_FILES["file"]["name"] . " already exists. ";
    }
    else if (!is_uploaded_file($_FILES['upload']["tmp_name"]))
    {
       $message = "Invalid File!";
    }
    else {
       $message = "";
       $move = move_uploaded_file($_FILES['upload']['tmp_name'], $url.$_FILES['upload']['name']);
       if(!$move)
       {
           $message = "Error moving uploaded file.";
       }
       $url = $url.$_FILES['upload']['name'];
       }
echo $message;
</script>";
?>

Now the thing is, it says "already exists". Why? I can see via the ftp client that file has not been uploaded

@hjpotter92 chmod($_FILES['upload']['tmp_name'], 777); $message = "success!"; $move = move_uploaded_file($_FILES['upload']['tmp_name'], $url.$_FILES['upload']['name']); & changed permissions of uploads folder as well... nothing works — P.C.
The fact that it says "already exists", not "Filename.jpg already exists" should be a hint... — a sad dude

dev-null-dweller dev-null-dweller · Accepted Answer · 2012-04-01T08:02:31

move_uploaded_file works on filesystem, not on urls.

instead of $url in

move_uploaded_file($_FILES['upload']['tmp_name'], $url.$_FILES['upload']['name']);

use filesystem path, ie:

move_uploaded_file($_FILES['upload']['tmp_name'], "/home/www/uploads/".$_FILES['upload']['name']);

PHP Image Upload Strange Issue

1 Answers