Custom table view cell: IBOutlet label is nil

54
votes

Consider the following simple view controller:

class ViewController: UIViewController, UITableViewDataSource {
    @IBOutlet weak var tableView: UITableView!

    var items = ["One", "Two", "Three"]

    override func viewDidLoad() {
        super.viewDidLoad()

        self.tableView.registerClass(CustomTableViewCell.self, forCellReuseIdentifier: "customCell")
        self.tableView.dataSource = self
    }

    func tableView(tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
        return self.items.count;
    }

    func tableView(tableView: UITableView, cellForRowAtIndexPath indexPath: NSIndexPath) -> UITableViewCell {
        let cell = self.tableView.dequeueReusableCellWithIdentifier("customCell") as CustomTableViewCell
        cell.titleLabel!.text = self.items[indexPath.row]
        return cell
    }
}

And custom cell view:

class CustomTableViewCell: UITableViewCell {
    @IBOutlet weak var titleLabel: UILabel!   
}

This code causes the following error.

fatal error: unexpectedly found nil while unwrapping an Optional value

titleLabel is nil — it's not clear why. Setting default properties of UITableViewCell (like textLabel) work just fine.

I'm using a nib for the custom cell.

Both the labels and table views are correctly connected to their IBOutlets.

labeltable view

Both the prototype cell and the custom nib view are marked as having a CustomTableViewCell class.

I'm new to iOS development, am I missing something obvious?

Sample Xcode project available.

6
iosuitableviewswiftinterface-builder
Is the cell here not nil? (let cell = self.tableView.dequeueReusableCellWithIdentifier("customCell") as CustomTableViewCell) – iOSfleer
You noticed the warning "/Main.storyboard:64: Prototype table cells must have reuse identifiers"? – qwerty_so
@ThomasKilian Adding a reuse identifier in the Attributes inspector removes the warning but does not affect the issue. – David Chouinard
@iOSfleer cell is not nil. For example, setting the cell's textLabel property causes the label to correctly appear in the UI. – David Chouinard
If you've made your cell in a xib file, you should register the nib, not the class (only register the class if the cell's subviews are created in code). – rdelmar

6 Answers

61
votes

First off, you're using a nib file to load your custom cell into the table. That's probably going to be more of a headache than it's worth if you're new to Swift/Cocoa. I would move everything over to storyboard for the time being. Instead of using a nib file click, go to Storyboard, click on your UITableView and make sure the TableView's content setting is Dyanamic Prototypes:

enter image description here

Next, click on the prototype cell (the only one in the table view) and set the class to CustomTableViewCell and set its reuse identifier to customCell:

enter image description hereenter image description here

Next, add a label to your prototype cell and link it to the IBOutlet in your CustomTableViewCell class. You don't need to register your customCell so long as you've set the reuse identifier in storyboard. Delete this line:

self.tableView.registerClass(CustomTableViewCell.self, forCellReuseIdentifier: "customCell")

and it should run.

44
votes

try this

import UIKit

class ViewController: UIViewController, UITableViewDataSource {
    @IBOutlet weak var tableView: UITableView!

    var items = ["One", "Two", "Three"]

    override func viewDidLoad() {
        super.viewDidLoad()

        self.tableView.registerNib(UINib(nibName: "CustomTableViewCell", bundle: nil), forCellReuseIdentifier: "customCell")// CustomTableViewCell.self, forCellReuseIdentifier: "customCell")
        self.tableView.dataSource = self
    }

    func tableView(tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
        return self.items.count;
    }

    func tableView(tableView: UITableView, cellForRowAtIndexPath indexPath: NSIndexPath) -> UITableViewCell {
        let cell = self.tableView.dequeueReusableCellWithIdentifier("customCell", forIndexPath: indexPath) as CustomTableViewCell
        cell.titleLabel!.text = self.items[indexPath.row]
        return cell
    }
}
12
votes

Register your nib like this: 

let bundle = Bundle(for: type(of: self))
let nib = UINib(nibName: "PickerCell", bundle: bundle)
collectionViewPicker.register(nib, forCellWithReuseIdentifier: "cell")
7
votes

You should use dequeueReusableCellWithIdentifier:forIndexPath to dequeue the cells.

If you are using storyboard to create the cells, you should not need to register the class for reuse as storyboard does it for you if you set the reuseIdentifier.

1
votes

Please make sure you are not doing any mistake while registering your nib(custom cell) in the viewdidload. Nib name and reuseIdentifiers should not be wrong.

-9
votes

Works for me without !

EDIT

    let challenge = self.challenges![indexPath.row]

    let title = challenge["name"]
    if title != nil {
        cell.titleLabel.text = title
    }