83
votes

I don't understand why in the following code, when I instanciate an object of type daughter, the default grandmother() constructor is called ?

I thought that either the grandmother(int) constructor should be called (to follow the specification of my mother class constructor), or this code shouldn't compile at all because of the virtual inheritance.

Here compiler silently calls grandmother default constructor in my back, whereas I never asked for it.

#include <iostream>

class grandmother {
public:
    grandmother() {
        std::cout << "grandmother (default)" << std::endl;
    }
    grandmother(int attr) {
        std::cout << "grandmother: " << attr << std::endl;
    }
};

class mother: virtual public grandmother {
public:
    mother(int attr) : grandmother(attr) {
        std::cout << "mother: " << attr << std::endl;
    }
};

class daughter: virtual public mother {
public:
    daughter(int attr) : mother(attr) {
        std::cout << "daughter: " << attr << std::endl;
    }
};

int main() {
  daughter x(0);
}
1
What compiler (and version)? With what arguments did you compile it? - orlp
gcc 4.6.3 20120306 (Red Hat 4.6.3-2) on fedora 15. Arguments are : -O0 -g3 -Wall -c -fmessage-length=0 - Simon Desfarges
g++ 4.1.2 has the same issue: codepad.org/L0jBXfSP - orlp
Ubuntu 4.7 snapshot with -Wall -pedantic-errors reproduces this. - juanchopanza

1 Answers

92
votes

When using virtual inheritance, the virtual base class's constructor is called directly by the most derived class's constructor. In this case, the daughter constructor directly calls the grandmother constructor.

Since you didn't explicitly call grandmother constructor in the initialization list, the default constructor will be called. To call the correct constructor, change it to:

daugther(int attr) : grandmother(attr), mother(attr) { ... }

See also This FAQ entry.