problems with echo img tag

0
votes

I'm having problems echoing the src and alt attribute in the img tag. It doesn't display the image at all. Does any one know how I should be structuring this?

echo '<td rowspan="7">' . <img src=$row[url] alt=$row[caption] height="250" width="300"/> . '</td>';

Thanks

6
php

6 Answers

3
votes

You need to enclose the <img> tag in the quotes (and don't forget the double quotes around attribute values):

echo '<td rowspan="7"><img src="' . $row['url'] . '" alt="' . $row['caption'] . '" height="250" width="300"/></td>';

Also, rather than concatenating the string, you can use commas to echo. It's a trivial performance boost (users will almost certainly never notice), but good to know nonetheless!

echo '<td rowspan="7"><img src="', $row['url'], '" alt="', $row['caption'], '" height="250" width="300"/></td>';

Don't forget to sanitize your $row data so a stray " doesn't break your site.

2
votes

Your img HTML still needs to be in a string if you're trying to concatenate it:

echo '<td rowspan="7">' . "<img src=$row[url] alt=$row[caption] height=\"250\" width=\"300\"/>" . '</td>';

or simpler:

echo "<td rowspan=\"7\"><img src=$row[url] alt=$row[caption] height=\"250\" width=\"300\"/></td>";
2
votes

Your quoting is all messed up:

To fix your method with single-quoting and concatenation, use:

echo '<td rowspan="7"><img src="' . $row['url'] . '" alt="' . $row['caption'] . '" height="250" width="300"/></td>';

Or all as a double-quoted string, enclosing the variables in {} and placing single quotes around all attributes:

echo "<td rowspan='7'><img src='{$row[url]}' alt='{$row['caption']}' height='250' width='300'/></td>";
1
votes

If I understand what you are after this should work:

echo '<td rowspan="7"><img src="{$row[url]}" alt="{$row[caption]}" height="250" width="300"/></td>';
0
votes

I suggest you to separate the html tags from your php code, like this:

<td rowspan="7"><img src="<?php echo $row[url] ?>" alt="<?php echo $row[caption] ?>" height="250" width="300"/></td>
0
votes
echo '<td rowspan="7"><img src=".$row[url].'" alt='".$row[caption].'" height="250" width="300"/></td>';