UIViewController viewDidLoad called before init method is complete

Question

I have a view controller that initializes two other view controllers. The view for one controller wasn't showing, and I tracked the problem to the instance being nil when it's added to the superview.

Here is the code. viewDidLoad is being called before the favoritesTableVC is initialized. I can see this by placing breakpoints in the initialization methods of the resultsTableVC and favoritesTableVC view controllers.

- (id)initWithNibName:(NSString *)nibNameOrNil bundle:(NSBundle *)nibBundleOrNil
{
    self = [super initWithNibName:nibNameOrNil bundle:nibBundleOrNil];
    if (self) {
        resultsTableVC = [[[ResultsTableVC alloc] initWithController:self andTableView:nil] retain];
        favoritesTableVC = [[[FavoritesTableVC alloc] initWithFrame:CGRectMake(0, 10, self.view.frame.size.width, defaultFavoritesTableHeight) andController:self] retain];        
    }
    return self;
}

- (void)viewDidLoad
{
    [super viewDidLoad];

    [self.view addSubview:resultsTableVC.view];
    [resultsTableVC release];
    [self.view addSubview:favoritesTableVC.view];
    [favoritesTableVC release];    
}

Here is the order the methods are being called:

allResults init
resultsTableVC init
allResults viewDidLoad
- addSubview allResultsVC
- addSubview favoritesResultsVC
favoritesResultsVC init

This is a single thread, so I don't understand how viewDidLoad can be called before init is complete.

Firoze Lafeer Firoze Lafeer · Accepted Answer · 2011-12-11T03:53:03

-[ResultsTableVC initWithController:andTableView:] is probably referencing allResults.view.

This would force the allResults controller to load its view (which then of course causes viewDidLoad to fire). All of this happens synchronously, before you actually return from initWithController:andTableView:

UIViewController viewDidLoad called before init method is complete

2 Answers