Listbox.Items.Clear() crashes on SelectionChanged

Question

private void lbcreatedRequests_SelectionChanged(object sender, SelectionChangedEventArgs e)
{

}

//Display Edit Page
private void btnEdit_Click(object sender, RoutedEventArgs e)
{
   lbcreatedRequests.Items.Clear(); //crash here 
   _loggedIn = Home._loggedIn;
    if (_loggedIn == true)
    {
       wcf.retrievecreatedrequestListAsync(Home.myID);
    }
}

Trying to clear the Listbox, before it load the new one again

Error

Object reference not set to an instance of an object.

at SGTaxiPool.Views.ShareCab.lbcreatedRequests_SelectionChanged(Object sender, SelectionChangedEventArgs e) at System.Windows.Controls.Primitives.Selector.OnSelectionChanged>(SelectionChangedEventArgs e) at System.Windows.Controls.Primitives.Selector.InvokeSelectionChanged(List1 unselectedItems, List1 selectedItems) at System.Windows.Controls.Primitives.Selector.SelectionChanger.End() at System.Windows.Controls.Primitives.Selector.OnItemsChanged(NotifyCollectionChangedEventArgs e) at System.Windows.Controls.ListBox.OnItemsChanged(NotifyCollectionChangedEventArgs e) at System.Windows.Controls.ItemsControl.OnItemCollectionChanged(Object sender, NotifyCollectionChangedEventArgs e) at System.Collections.Specialized.NotifyCollectionChangedEventHandler.Invoke(Object >sender, NotifyCollectionChangedEventArgs e) at System.Windows.Controls.ItemCollection.NotifyCollectionChanged>(NotifyCollectionChangedEventArgs e) at System.Windows.Controls.ItemCollection.ClearImpl() at System.Windows.PresentationFrameworkCollection`1.Clear() at SGTaxiPool.Views.ShareCab.btnEdit_Click(Object sender, RoutedEventArgs e) at System.Windows.Controls.Primitives.ButtonBase.OnClick() at System.Windows.Controls.Button.OnClick() at System.Windows.Controls.Primitives.ButtonBase.OnMouseLeftButtonUp(MouseButtonEventArgs e) at System.Windows.Controls.Control.OnMouseLeftButtonUp(Control ctrl, EventArgs e) at MS.Internal.JoltHelper.FireEvent(IntPtr unmanagedObj, IntPtr unmanagedObjArgs, Int32 argsTypeIndex, Int32 actualArgsTypeIndex, String eventName

How can this possibly have 3 upvotes? There is no info at all — Oskar Kjellin
BrokenGlass' answer was correct. Too bad he deleted it. He linked to this: forums.silverlight.net/p/17967/73247.aspx — Hans Passant
Hopefully @BrokenGlass can add the answer again. Just tried it and he was correct. The exception given is InvalidOperationException with the message Cannot change ItemCollection during a OnItemsChanged event. — Oskar Kjellin
Well guess I'm undeleting then, who knew - I wasn't sure this still applies on the full release, that thread was about Beta 2 — BrokenGlass
@Tedd Don't change the entire question. This is not the same question as before — Oskar Kjellin

BrokenGlass BrokenGlass · Accepted Answer · 2011-08-29T13:18:16

This thread suggests a workaround for this problem is to do this on the Dispatcher thread:

private void lbcreatedRequests_SelectionChanged(object sender, SelectionChangedEventArgs e)
{
   Dispatcher.BeginInvoke(() => { lbcreatedRequests.Items.Clear(); });
}

Listbox.Items.Clear() crashes on SelectionChanged

1 Answers