ProtoBuf-net AsReference require public constructor in Activator.CreateInstance?

Question

While working on 2 of my classes that looks like this (minimal)

using System;
using System.Collections.Generic;
using System.Collections;
using System.ComponentModel;
using System.Drawing;
using System.Windows.Forms;
using System.IO;
using ProtoBuf;

namespace Sandbox
{
    public partial class Form1 : Form
    {
        public Form1()
        {
            Family family = new Family();
            Child child1 = new Child(1);
            Child child2 = new Child(2);
            Parent parent = new Parent(new List<Child>() { child1, child2 });
            family.Add(parent);

            string file = "sandbox.txt";

            try { File.Delete(file); } catch { }

            using (var fs = File.OpenWrite(file)) { Serializer.Serialize(fs, family); }
            using (var fs = File.OpenRead(file)) { family = Serializer.Deserialize<Family>(fs); }

            System.Diagnostics.Debug.Assert(family != null, "1. Expect family not null, but not the case.");
        }
    }

    [ProtoContract()]
    public class Child
    {
        [ProtoMember(1, AsReference = true)]
        internal Parent Parent;

        private Child() { }

        public Child(int i) { }
    }

    [ProtoContract()]
    public class Parent
    {
        [ProtoMember(1)]
        protected List<Child> m_Children;

        /// <summary>
        /// ProtoBuf deserialization constructor (fails here)
        /// </summary>
        private Parent() { m_Children = new List<Child>(); }

        public Parent(List<Child> children)
        {
            m_Children = children;
            m_Children.ForEach(x => x.Parent = this);
        }
    }

    [ProtoContract()]
    public class Family
    {
        [ProtoMember(1)]
        protected List<Parent> m_Parents;

        public void Add(Parent parent)
        {
            m_Parents.Add(parent);
        }

        public Family()
        {
            m_Parents = new List<Parent>();
        }
    }
}

During deserialization, I encounter the exception "No parameterless constructor defined for this object." for creating the Parent object in ProtoBuf.BclHelper near

case FieldObject:
// ...
value = ((options & NetObjectOptions.UseConstructor) == 0) ? BclHelpers.GetUninitializedObject(type) : Activator.CreateInstance(type);

Then when I changed the default constructor Parent() to public, the exception goes away.

Any idea what ~~I may have overlooked~~ is the correct usage for AsRerference in this case?

BOUNTY: While Marc takes his time to fix the issue, I would require a definitive solution to use protobuf-net in this situation, working around either by protobuf-net attributes, methods or other tricks. Otherwise I will have to abandon the use of protobuf-net altogether. Thanks for any help.

I've just returned from a few days away. I will look at this later. — Marc Gravell
Looking at this briefly, I think there is an edge case relating to inheritance and reference-tracking; I know how to resolve it - it just needs a few tweaks to fix. — Marc Gravell
@Marc Thanks for being here. Really apprecatiate your contributions. If you ever get time to have this sorted hopefully you will update the answer here. Thanks again. — Jake

Simon Mourier Simon Mourier · Accepted Answer · 2011-09-22T17:54:17

I believe you can do this to fix this problem:

[ProtoContract(SkipConstructor = true)]
public class Parent
{
    [ProtoMember(1)]
    protected List<Child> m_Children;

    private Parent() { Initialize(); }

    [ProtoBeforeDeserialization] // could also use OnDeserializing
    private void Initialize()
    {
        m_Children = new List<Child>();
    }

    public Parent(List<Child> children)
    {
        m_Children = children;
        m_Children.ForEach(x => x.Parent = this);
    }

}

ProtoBuf-net AsReference require public constructor in Activator.CreateInstance?

2 Answers