ValueError: The view blog.views.post_search didn't return an HttpResponse object. It returned None instead

Question

I'm implementing "search function" to my django blog, using Solr and Haystack. In "http://127.0.0.1:8000/blog/search/", it says TypeError at /blog/search/ post_detail() missing 3 required positional arguments: 'year', 'month', and 'day' Also in "http://localhost:8000/blog/search", it says ValueError at /blog/search The view blog.views.post_search didn't return an HttpResponse object. It returned None instead.

blog/forms.py


    from django import forms
    
    class SearchForm(forms.Form):
        query = forms.CharField()

blog/search_indexes.py


    from haystack import indexes
    from .models import Post
    
    class PostIndex(indexes.SearchIndex, indexes.Indexable):
        text = indexes.CharField(document=True, use_template=True)
        publish = indexes.DateTimeField(model_attr='publish')
    
        def get_model(self):
            return Post
    
        def index_queryset(self, using=None):
            return self.get_model().published.all()

blog/urls.py


    from blog.feeds import LatestPostsFeed
    from django.conf.urls import url
    from django.urls import include, path
    from . import views
    
    app_name = 'blog'
    
    urlpatterns = [
        path('search', views.post_search, name='post_search'),
    ]

blog/views.py


    from .forms import SearchForm
    from haystack.query import SearchQuerySet
    
    def post_search(request):
        form = SearchForm()
        if 'query' in request.GET:
            form = SearchForm(request.GET)
            if form.is_valid():
                cd = form.cleaned_data
                results = SearchQuerySet().models(Post).filter(content=cd['query']).load_all()
                # count total results
                total_results = results.count()
                return render(request, 'blog/post/search.html', {'form': form, 'cd': cd, 'results': results, 'total_results': total_results})

blog/templates/blog/post/search.html


    {% extends "blog/base.html" %}
    
    {% block title %}Search{% endblock %}
    
    {% block content %}
        {% if "query" in request.GET %}
            <h1>Posts containing "{{ cd.query }}"</h1>
            <h3>Found {{ total_results }} result{{ total_results|pluralize}}</h3>
            {% for result in results %}
                {% with post=result.object %}
                    <h4><a href="{{ post.get_absolute_url }}">{{ post.title }}</a></h4>
                    {{ post.body|truncatewords:5 }}
                {% endwith %}
            {% empty %}
                <p>There are no results for your query.</p>
            {% endfor %}
            <p><a href="{% url 'blog:post_search' %}">Search again</a></p>
        {% else %}
            <h1>Search for posts</h1>
            <form action="." method="get">
                {{ form.as_p }}
                <input type="submit" value="Search">
            </form>
        {% endif %}
    {% endblock %}

blog/templates/search/indexes/blog/post_text.txt


    {{ object.title }}
    {{ object.tags.all|join:", " }}
    {{ object.body }}

Lars Lars · Accepted Answer · 2021-09-03T06:34:22

Try to do it like :-

    def post_search(request):
        form = SearchForm()
        if 'query' in request.GET:
            form = SearchForm(request.GET)
            if form.is_valid():
                cd = form.cleaned_data
                results = SearchQuerySet().models(Post).filter(content=cd['query']).load_all()
                # count total results
                total_results = results.count()
#Changed some indention Here
        return render(request, 'blog/post/search.html', {'form': form, 'cd': cd, 'results': results, 'total_results': total_results})

What have i changed :-

You were passing the return render within if statement so Django assumed that return render is the part of if starement.

ValueError: The view blog.views.post_search didn't return an HttpResponse object. It returned None instead

1 Answers