Bot assigns user a role, even if user doesn't own role

Question

Sorry for the confusing title, I'll clarify. I'm trying to make the bot check if a user has a certain role in their quick.db inventory, and if they do, it'll equip that role. The problem I'm having is that even with the role in the inventory, it returns the error that the role isn't owned. I have a feeling that the problem is the if (db.has(message.author.id + '.hot rod red')) line, as I'm not too sure how to format checking for a role with quick.db. Sorry for the messy code, if anyone knows how to fix this let me know, thanks!

if (db.has(message.author.id + '.hot rod red')) {
  if (message.member.roles.cache.some(role => role.name === 'hot rod red')) {
    let embed = new Discord.MessageEmbed().setDescription('You already have this role equipped!');
    return message.channel.send(embed);
  } else {
       await message.guild.members.cache.get(user.id).roles.add('733373020491481219');

       let embed = new Discord.MessageEmbed().setDescription(`You now have the ${message.guild.roles.cache.get('733373020491481219')} role!`);
       message.channel.send(embed);
       user.roles.remove(user.roles.highest);
  }
} else {
    let embed = new Discord.MessageEmbed().setDescription('You do not own this role!'); // ERROR HERE; GIVES ROLE EVEN WITHOUT OWNING
    return message.channel.send(embed);
}

try console.log(db.get(message.author.id + '.hot rod red')) to check if the user actually has the role — a.mola
Doesn't look like that worked, it still returns the same thing, but now in the console, it returns false. Could it have something to do with the formatting of .hot rod red? It's a role, so it shows in the inventory as "@hot rod red" — washingm

Jeffplays2005 Jeffplays2005 · Accepted Answer · 2021-03-14T05:43:41

Probably try something like let check = db.get(message.author.id+'.hot rod red') and check if it is true/false, I'd say to use string rather then boolean as you can use if(check === 'false/true'){}. You can also do

if(!check || check === 'false'){ return 
let embed = new Discord.MessageEmbed().setDescription('You do not own this role!');
return message.channel.send(embed);
 }

So the final code would be:

let check = await db.get(message.author.id + '.hot rod red');
let rejectEmbed = new Discord.MessageEmbed()
.setDescription('You do not own this role!');

if(!check){
return message.channel.send(rejectEmbed) 
}
if(check === 'true'){
if (message.member.roles.cache.some(role => role.name === 'hot rod red')) {
    let embed = new Discord.MessageEmbed().setDescription('You already have this role!');
    return message.channel.send(embed);
  } else {
       await message.guild.members.cache.get(user.id).roles.add('733373020491481219');

       let embed = new Discord.MessageEmbed().setDescription(`You now have the ${message.guild.roles.cache.get('733373020491481219')} role!`);
       message.channel.send(embed);
       user.roles.remove(user.roles.highest); // I'm unsure why this is here, this could be causing a potential error
  }
}

If there are any more questions, please comment!! I hope this has helped.

Bot assigns user a role, even if user doesn't own role

1 Answers