Create Pointcut for Spring AOP annotation to put annotation on class and execute advice on every method in class

Question

I want to have annotation on class level that will execute advice on every method in annotated class. Is that even possible.

Example: I would like to annotate OmniDemoService with @DoSomethingForMe and I want both method1 and method2 to log "look at me" before execution

This example is not working and I don't know why. When I transform Pointcut to Around and just use it with annotation (also change annotation ElementType to method) everything is working on method level. So I think it is wrong defined Pointcut.

Annotation:

@Target(ElementType.TYPE)
@Retention(RetentionPolicy.RUNTIME)
public @interface DoSomethingForMe {
}

Advice:

@Aspect
@Component
public class DoSomethingForMeAdvice {

    private static final Logger logger = LoggerFactory.getLogger(DoSomethingForMeAdvice.class);

    @Pointcut("execution(public * *(..)) && @annotation(DoSomethingForMe)")
    public void anyAnnotatedMethod() {
    }

    @Before("anyAnnotatedMethod()")
    public void acquireExecution() {
        logger.info("look at me");
    }
}

Usage:

@Service
@DoSomethingForMe
public class OmniDemoService {

    private static final Logger logger = LoggerFactory.getLogger(OmniDemoService.class);

    public void method1() {
            logger.info("---1---");
    }
    
    public void method2() {
            logger.info("---2---");
    }
}

yes, that is possible, I don't really understand the actual question. What is the question you are having? — Stultuske
This is not working for me. Probably Pointcut is not defined well. — mladirazvijac
this might be a good read: baeldung.com/spring-aop-annotation — Stultuske
This is just simple explanation of usage of advice on method level with @Around — mladirazvijac
Yes, I know. What is your point? have you tried copying that configuration, changing the target type and changing the location of the annotation? — Stultuske

J Asgarov J Asgarov · Accepted Answer · 2020-08-21T06:34:42

Your issue is that you are confusing pointcut definition with advices.

Pointcut is aiming, advice performs the actual WhateverYouWantToBeExecuted. Like for example

@Pointcut("@annotation(com.omnidemo.advice.DoSomethingForMe)")
public void anyAnnotatedMethod() {
}


@Before("anyAnnotatedMethod()")
public void logMethodCall(JoinPoint jp) {
    String methodName = jp.getSignature().toShortString();
    logger.info("Executing: " + methodName);
}

Create Pointcut for Spring AOP annotation to put annotation on class and execute advice on every method in class

3 Answers