0
votes

I have in MyViewModel class variable MutableLiveData items which stores, list of Item class. There is also fuction fetchData() which gets data from webService by Retrofit library and checkStatus() function which for every item on list should perform check when user click the button.

My question is: what is the proper way to update item on list stored in MutableLiveData object? Is my solution acceptable or do you know any better solution?

Item.java

public class Item {
    int id;
    String status;
}

MyViewModel.java

public class MyViewModel extends ViewModel {

    private MutableLiveData<List<Item>> items = new MutableLiveData<>();
    //... rest of variables

    public void fetchData() {
        // get list from webService

        webService.fetchItems()
                .subscribeOn(Schedulers.io())
                .observceOn(AndroidSchedulers.mainThread())
                .observe(result -> items.postValue(result.data));
    }

    public void checkStatus() {
        // for every item on list perform check

        List<Item> itemList = items.getValue();
        for(Item item : itemList) {
            webService.check(item.id)
                    .subscribeOn(Schedulers.io())
                    .observeOn(AndroidSchedulers.mainThread())
                    .observe(result -> {
                        item.status = result.status;
                        itemList.set(itemList.indexOf(item), item);
                        items.postValue(items.getValue());
                    });
        }
    }
}

MainActivity.java

public class MainActivity extends AppCompatActivity {

    private RecyclerViewAdapter viewAdapter;
    private MyViewModel viewModel;
    // rest of standard code...


    // called somewhere in onCreate method
    private void subscribeObservers() {
        viewModel.observeItems().observe(this, items -> {
            if(items != null) {
                viewAdapter.setItems(items);
            }
        });
    }

    // user check click button listener
    public void onClick(View view) {
        viewModel.checkStatus();
    }
}

1

1 Answers

0
votes

I think you can use repository for mvvm architecture. You can refer at here