Symfony 3 - Cannot correctly manage my user roles in PROD environment

Question

I have a problem on symfony 3. I'm trying to manage my roles from a page I created. The role system I use is the same as the one used by FOSUserBundle.

/**
 * @ORM\Column(type="array")
 */
protected $roles = [];


/**
 * Constructor
 */
public function __construct()
{
    $this->setIsActif(true);
    $this->roles = array();

}

 /**
 * {@inheritdoc}
 */
public function addRole($role)
{
    $role = strtoupper($role);
    if ($role === ['ROLE_USER']) {
        return $this;
    }

    if (!in_array($role, $this->roles, true)) {
        $this->roles[] = $role;
    }

    return $this;
}

/**
 * {@inheritdoc}
 * @return array
 */
public function getRoles()
{
    return array_unique(array_merge(['ROLE_USER'], $this->roles));
}

/**
 * Vérifie si l'utilisateur possède le rôle passé en paramètre
 * {@inheritdoc}
 * 
 * @param string
 * @return bool
 */
public function hasRole($role)
{
    return in_array(strtoupper($role), $this->getRoles(), true);
}

/**
 * Supprimer un rôle
 * {@inheritdoc}
 * 
 * @return UserCas
 */
public function removeRole($role)
{
    if (false !== $key = array_search(strtoupper($role), $this->roles, true)) {
        unset($this->roles[$key]);
        $this->roles = array_values($this->roles);
    }

    return $this;
}

/**
 * Set roles
 * {@inheritdoc}
 * 
 * @return UserCas
 */
public function setRoles(array $roles)
{
    $this->roles = array();

    foreach ($roles as $role) {
        $this->addRole($role);
    }

    return $this;
}

/**
 * Réinitialise les rôles de l'utilisateur
 */
public function resetRoles()
{
    $this->roles = [];
}

When I was in a "PREPROD" environment, everything was working, my roles were changing well. But since I switched to "PROD", when my user does not have a role (so it is automatically ROLE_USER), well 9 times out of 10, I can not assign any other role. But if he has a role other than ROLE_USER, then I can assign him any role. Why does not it work in preprod? I do not know...

On twig, I have my list of users with a list option where I choose the new role. Then it updates the page. My request retrieves the label of the new role and is assigned

Twig:

<form action="{{path('user_role_change', {'username': unUser.username })}}" method="POST">
                        <select id="role" name="role" onChange="this.form.submit();">
                            {% for unRole in listeRoles %}
                            <option value="{{unRole}}" {% if unRole == 'User' %} selected {% endif %}>{{unRole}}</option>
                            {% endfor %}
                        </select>
                    </form>

Controller:

/**
     * Change le rôle d'un utilisateur lorsque l'on change l'option dans l'option list des rôles d'un utilisateur
     *
     * @Route("/changeRole/{username}", name="user_role_change")
     * @Method("GET")
     */
    public function changeRoleAction(Request $request, $username)
    {
        $em = $this->getDoctrine()->getManager();

        $idRole=$request->get('role');

        $user = $em->getRepository('PagesBundle:UserCas')->findOneByUsername($username); // On cherche si c'est un UserCas (user académique)

        if($user == null)
        {
            $user = $em->getRepository('PagesBundle:User')->findOneByUsername($username); // On cherche si c'est un User externe


        $nouveauRole = $this->getNouveauRole($idRole);

        $user->setRoles($nouveauRole);
        $em->persist($user);
        $em->flush();

        return $this->redirectToRoute('roles_index'); //redirection vers la page de gestion des Informations
    }



/**
 * Méthode inverse de $this->switchRole()
 * Elle renvoi le rôle en type array de sorte à ce qu'elle soit injectable dans l'attribut roles de l'utilisateur ( ex: "Admin" => "ROLE_ADMIN")
 * 
 * @param int $nomRole
 * @return array
 */
public function getNouveauRole($nomRole)
{
    switch($nomRole)
    {
        case "Admin":
            $role = ['ROLE_ADMIN'];
            break;

        case "Packages":
            $role = ['ROLE_PACKAGES'];
            break;

        case "Infos":
            $role = ['ROLE_INFOS'];
            break;

        default:
            $role = [];
            break;
    }

    return $role;
}

Can someone help me please ?

Mohamed Radhi Guennichi Mohamed Radhi Guennichi · Accepted Answer · 2019-05-22T12:38:55

Try to fix your addRole() method like the following:

 /**
 * {@inheritdoc}
 */
public function addRole($role)
{
    $role = strtoupper($role);
    if ($role === 'ROLE_USER') {
        return $this;
    }

    if (!in_array($role, $this->roles, true)) {
        $this->roles[] = $role;
    }

    return $this;
}

Symfony 3 - Cannot correctly manage my user roles in PROD environment

1 Answers