Method Illuminate\Support\Collection::offset does not exist

Question

Hi i'm trying to paginate my view and i have this following code in my controller for the pagination:

    public function membrevis()
      {
      $filter = isset($_GET['filter']) ? $_GET['filter'] : null;
      $query = DB::table('users')
        ->join('user_role', 'users.id', '=', 'user_role.user_id')
        ->join('roles', 'user_role.role_id', '=', 'roles.id')
        ->where('users.valid','=',0)
        ->select('users.*','roles.description');
        if ($filter != null) {
        $query->where('users.name','like','%'.$filter.'%')
            ->orWhere('roles.description','like','%'.$filter.'%');
        }
     $users = $query->get();


    $itemsPerPage = 8 ;
    $currentPage  = isset( $_GET['page'] ) && is_numeric( $_GET['page'] ) ? $_GET['page'] : 1;
    $urlPattern   = '/profilecontroller/membrevis?page=(:num)';
    $totalItems   = $users->count();
    $donner   = $users->offset( ( $currentPage - 1 ) * $itemsPerPage )->limit( $itemsPerPage )->get();
    $paginator = new  Paginator( $totalItems, $itemsPerPage, $currentPage, $urlPattern );

return view('membre2',['users'=> $donner,'paginator'=> $paginator]);

My view membre2.blade.php has the following code as well for pagination:

  <form>
 ....
  </form>
 <table>
@foreach($users as $row)
....
@endforeach
 </table>
echo $paginator;

But i' still get this error Method Illuminate\Support\Collection::offset does not exist. knowing i already installed "jasongrimes/paginator:~1.0" by CMD

any help would be appreciated!

what is $users query in your controller? show your code completely. — Mehdi Alipour
before $donner code what is dd(get_class($user)) it is printed Illuminate\Support\Collection; — Davit
@MehdiAlipour I just update my post with the full code of my controller profilecontroller.php — H.tay

Davit Davit · Accepted Answer · 2018-06-09T10:29:50

Illuminate\Support\Collection::offset does not exist. it is because your $users is instance of Illuminate\Support\Collection. For check it use dd(get_class($users)); after $totalItems = $users->count(); It must be print Illuminate\Support\Collection. Collection instance has count method, which return Collection items count. For your $users->offset( ( $currentPage - 1 ) * $itemsPerPage )->limit( $itemsPerPage )->get() code work right you must be change $users to $query(maybe $users) where $query(maybe $users) isntance of \Illuminate\Database\Query\Builder.
For this case use

$query->->offset( ( $currentPage - 1 ) * $itemsPerPage )->limit( $itemsPerPage )->get();

Your corrected code is

public function membrevis()
{
    $filter = isset($_GET['filter']) ? $_GET['filter'] : null;
    $query = DB::table('users')
        ->join('user_role', 'users.id', '=', 'user_role.user_id')
        ->join('roles', 'user_role.role_id', '=', 'roles.id')
        ->where('users.valid','=',0)
        ->select('users.*','roles.description');
    if ($filter != null) {
        $query->where('users.name','like','%'.$filter.'%')
            ->orWhere('roles.description','like','%'.$filter.'%');
    }

    $itemsPerPage = 8 ;
    $currentPage  = isset( $_GET['page'] ) && is_numeric( $_GET['page'] ) ? $_GET['page'] : 1;
    $urlPattern   = '/profilecontroller/membrevis?page=(:num)';
    $totalItems   = $query->count();
    $donner   = $query->offset( ( $currentPage - 1 ) * $itemsPerPage )->limit( $itemsPerPage )->get();
    $paginator = new  Paginator( $totalItems, $itemsPerPage, $currentPage, $urlPattern );

    return view('membre2',['users'=> $donner,'paginator'=> $paginator]);
}

I delete $users = $query->get() method which is one more request in db. And for get total user count you used $totalItems = $query->count(); which is more optimized query

Method Illuminate\Support\Collection::offset does not exist

1 Answers