Angular 5 BehaviourSubject unsubscribe

Question

I made a BehaviourSubject inside a service in angular:

@Injectable()
export class UsuarioService {
  private _altaUsuarioData: BehaviorSubject<AltaUsuarioProvMunModel>;

  constructor(private http: HttpClient) {
    this._altaUsuarioData = new BehaviorSubject(new AltaUsuarioProvMunModel());
  }

  getAltaUsuarioData() {
     return this._altaUsuarioData.asObservable();
 }

I'm accesing it in another component:

  this.datosAltaUsuario: Observable<AltaUsuarioProvMunModel>;

  constructor(){
  this.datosAltaUsuario = this.usuarioService.getAltaUsuarioData();
    this.datosAltaUsuario.subscribe(
      resp => {
            ...

How can I unsubscribe from the BehaviourSubject?.
Does onDestroy takes care of it?.
Am I doing good creating the instance with asObservable() and creating the observable "this.datosAltaUsuario: Observable;"?
I'm a bit worried about possible memory leaks

Thank you in advance

Unknown Unknown · Accepted Answer · 2018-04-26T09:34:43

this['subscription'] = this.datosAltaUsuario.subscribe();, then this['subscription'].unsubscribe();
You can do it in ngOnDestroy, but it doesn't do it implicitly : you have to write the unsbuscribe.
I don't know about the best practice, but it's definitely not the worst practice.
If you unsubscribe you don't have to worry.

Angular 5 BehaviourSubject unsubscribe

1 Answers