Cannot override Laravel Spark authentication with own implementation

Question

During the login process of Laravel Spark I need to request a token of a remote API. This API stores the exact same users and passwords as the Laravel Spark application. Therefore I need to get the username and non hashed password of the user during the authentication process.

I thought overriding the authenticated method would be the solution to my problem. In routes/web.php I override the POST /login endpoint and am pointing this endpoint to my own LoginController:

<?php

namespace App\Http\Controllers\Auth;

use Illuminate\Support\Facades\Log;
use Illuminate\Http\Request;
use Laravel\Spark\Http\Controllers\Auth\LoginController as SparkLoginController;

class LoginController extends SparkLoginController
{
    /**
     * Create a new login controller instance.
     *
     * @return void
     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Handle a successful authentication attempt.
     *
     * @param  Request  $request
     * @param  \Illuminate\Contracts\Auth\Authenticatable  $user
     * @return Response
     */
    public function authenticated(Request $request, $user)
    {
        Log::info('authenticated method in LoginController has been called');

        return parent::authenticated($request, $user);
    }
}

This implementation throws a Missing argument 2 for App\Http\Controllers\Auth\LoginController::authenticated() exception. Somehow Laravel is not passing a User in the $user parameter. This exception is thrown whatever I do. Even removing the method out of my LoginController will result in the same exception thrown in the Spark LoginController.

When i disable my /login endpoint and log the $request and $user parameters of the authenticated method in the Spark LoginController, I see that $request contains Illuminate\Http\Request::__set_state(array(...)) and $user contains App\User::__set_state(array()). When I log the same in my own controller $request contains Illuminate\Http\Request::__set_state(array(...)) and $user is not passed.

Yokovaski Yokovaski · Accepted Answer · 2017-08-18T11:44:28

It turned out that my POST /login route did not call the right function. It called Auth\LoginController@authenticated and it should call Auth\LoginController@login.

How the complete route should look: Route::post('/login', 'Auth\LoginController@login');

Stupid mistake, but maybe it will help someone in the future facing the same problem.

Cannot override Laravel Spark authentication with own implementation

1 Answers