iPhone NSMutableDictionary setObject forKey after initWithContentsOfFile

Question

so here's my function

+ (void) AddAddress:(NSString*)ip:(NSString*)mac {
    NSMutableDictionary* currentAddresses = [[NSMutableDictionary alloc] initWithContentsOfFile:[self filePath:ADDRESSES_FILE]];
    [currentAddresses setObject:mac forKey:ip];
    [Configuration Write:currentAddresses];
    [currentAddresses release];
}

[self filePath:ADDRESSES_FILE] returns a string containing the full path of a file (ADDRESSES_FILE) located in the Documents. The file may not exist, in this case I want to just write an object to the dictionary and then write it down

the problem is that when i do setObject forKey it doesn't add anything to the dict (if i just do alloc init to the dict, it works fine, but i want to read the records from the file, if there are any, and replace/add a record by using the AddAddress function)

AddAddress:: isn't a descriptive method name (and entirely against Objective-C convention). Try addIPAddress:mac: instead. As well, method names should begin with lower case letters; write:, not Write: (the exception being things like URLWithString:; acronyms. — bbum
thank you, i just started objective C and just getting used to it — Andrei S

Psycho Psycho · Accepted Answer · 2011-01-01T15:51:28

First thing first, you'd rather respect naming convention of ObjC to be more easily understood... For instance, method names start with a small case and it's better to put a descriptive name before the colons for each arguments, a method name like that: AddAddress:: isn't really good...

Now, about loading a dictionary from a file, the thing is that if the file can't be loaded (doesn't exist, wrong format,...), the returned object will be nil, the simplest way to correct that is to put:

if(currentAddresses == nil) currentAddresses = [[NSMutableDictionary alloc] init];

iPhone NSMutableDictionary setObject forKey after initWithContentsOfFile

1 Answers