$apply in angularJs not updating my scope variables

Question

I am building an angular ionic app using meteor framework so far so good, but I am trying to update my scope using $apply method which is not updating my scope, here is my code. To be more specific the user after uploading the image calls addAvatar function() which converts the image to a base64 object using fileReader API. Which in turn must be assigned to editProfileController.cropImgSrc using $apply but its not happening.

I am trying to update scope of editProfileController.cropImgSrc

Template(directive)

<ion-view view-title="Profile Edit">
<div class="bar bar-header bar-positive">
    <h1 class="title">edit your profile</h1>
</div>
<ion-content overflow-scroll="true" class="has-header">
    <h4 style="color:#212121;font-family: 'proxima',sans-serif;">Edit profile</h4>
    <div class="row row-center">
        <div class="col col-25">
            <div>
                {{editProfileController.cropImgSrc}}
            </div>
        </div>
        <div class="col">
            <div class="button button-outline button-positive" ngf-select
                    ngf-change="editProfileController.addAvatar($files)"
                    ngf-multiple="false" ngf-allow-dir="false" ngf-accept="'image/*'"
                    ngf-drop-available="false">
                edit my display picture
            </div>
        </div>
    </div>
    <div class="list">
        <div class="list">
            <label class="item item-input">
                <span class="input-label">your name</span>
                <input type="text" ng-model="editProfileController.profile.name">
            </label>
            <label class="item item-input">
                <span class="input-label">your birthday</span>
                <input type="date" ng-model="editProfileController.profile.birthday">
            </label>
            <label class="item item-input item-select">
                <div class="input-label">
                    Gender
                </div>
                <select ng-model="editProfileController.profile.gender">
                    <option selected>Female</option>
                    <option>Male</option>
                    <option>Others</option>
                </select>
            </label>
        </div>
        <h5 style="color:#212121;font-family: 'proxima',sans-serif;" class="padding">Add a short Bio about you, Keep it interesting and simple!</h5>
        <label class="item item-input">
            <span class="input-label">Bio</span>
            <input type="text" placeholder="I am a storm trooper, fighting at star wars." ng-model="editProfileController.profile.bio">
        </label>
        <br>
        <div class="row padding">
            <div class="col">
                <button class="button button-outline button-positive button-block">
                    save my profile
                </button>
            </div>
        </div>
    </div>
</ion-content>

Controller

angular.module('appName').directive('profileedit',function(){
return{
    restrict: 'E',
    templateUrl: 'client/modules/profile-edit/profile-edit.html',
    controllerAs: 'editProfileController',
    controller: function($scope,$reactive){
        $reactive(this).attach($scope);
        this.helpers({
            cropImgSrc: function(){
                return ' ';
            }
        });
        this.addAvatar = function(files){
            if (files.length > 0) {
                var reader = new FileReader();
                reader.onload = function(e) {
                    $scope.$apply(function(){
                        this.cropImgSrc = e.target.result;
                    });
                };
                reader.readAsDataURL(files[0]);
            }
            else {
                this.cropImgSrc = undefined;
            }
        };
    }
}

});

Solution attach this to vm above the controller definetion, var vm = this;

Should not this this.cropImgSrc = e.target.result; be this.helpers.cropImgSrc = e.target.result; ? — Coder John
No, this is attached to $scope but still even if i added helpers it gives cannot get function of undefined. — user4356476

gnerkus gnerkus · Accepted Answer · 2016-03-28T09:44:38

The error occurs because the context of this has changed within the $scope.$apply method call.

See: this context within an event handler

A simple fix would be to save the context of this in a variable at the top of the controller's definition:

controller: function($scope,$reactive){
    // save context of this in a variable
    var vm = this;
    $reactive(this).attach($scope);
    this.helpers({
        cropImgSrc: function(){
            return ' ';
        }
    });
    this.addAvatar = function(files){
        if (files.length > 0) {
            var reader = new FileReader();
            reader.onload = function(e) {
                $scope.$apply(function(){
                    // vm still refers to the controller here
                    vm.cropImgSrc = e.target.result;
                });
            };
            reader.readAsDataURL(files[0]);
        }
        else {
            this.cropImgSrc = undefined;
        }
    };
}

$apply in angularJs not updating my scope variables

1 Answers