Codeigniter 3 login check function not showing correct flashdata messages

Question

I am creating a login check function. But my two flash data messages are not setting correct.

If user has logged on and then if the session expires it should set this flash data message Your session token has expired!
And if the user has not logged on and tries to access a controller with out logging on then it should set this flashdata message You need to login to access this site!

For some reason it is always showing the second flashdata message.

Question: How am I able to use the two flashdata messages properly.

Controller: Login.php Function: check

public function check() {
    $uri_route = basename($this->router->directory) .'/'. $this->router->fetch_class();

    $route = isset($uri_route) ? $uri_route : '';

        $ignore = array(
            'common/login',
            'common/forgotten',
            'common/reset'
        );

        if (!in_array($route, $ignore)) {

            // $this->user->is_logged() returns the user id

            if ($this->user->is_logged()) {

                // $this->session->userdata('is_logged') returns true or false

                if (!$this->session->userdata('is_logged')) {

                    // Redirects if the user is logged on and session has expired!

                    $this->session->set_flashdata('warning', 'Your session token has expired!');

                    redirect('admin/common/login');
                }

            } else {

                $this->session->set_flashdata('warning', 'You need to login to access this site!');

                redirect('admin/common/login');

            }
    }

I run function via codeigniter hook that way I do not have to add it on every controller.

$hook['pre_controller'] = array(
        'class'    => 'Login',
        'function' => 'check',
        'filename' => 'Login.php',
        'filepath' => 'modules/admin/controllers/common'
);

Be aware of that $uri_route will be isset every request because of concatenating slash. Second, following your description seems you are not logged in. Because it is what you get in else condition. Now, you need to check and/or post code when is this method used for more. — Tpojka

Ilanus Ilanus · Accepted Answer · 2015-11-21T05:15:55

What are you trying to check via the uri() is actually a very bad way of checking, also you should include login checks as a construct function not single.. here is what your function should look like:

    function __construct()
    {
        parent::__construct();
        if (!$this->session->userdata('logged_in')) {
        // Allow some methods?
            $allowed = array(
                'some_method_in_this_controller',
                'other_method_in_this_controller',
            );
            if (!in_array($this->router->fetch_method(), $allowed)
            {
            redirect('login');
           }
        }
    }

Codeigniter 3 login check function not showing correct flashdata messages

1 Answers