TwoWay Binding is not working if Binding is changed from DataTrigger

Question

I have the following DataTemplate for my Tool Bar Items:

<DataTemplate DataType="{x:Type viewModels:PopupContextActionViewModel}">
   <Grid>
      <ToggleButton Name="ToggleButton">
         <ContentControl Template="{Binding Icon, Converter={StaticResource NameToResourceConverter}}" Margin="5" />
      </ToggleButton>
      <Popup Name="ContextActionPopup" StaysOpen="False" AllowsTransparency="True"
         IsOpen="{Binding 
            ElementName=ToggleButton, 
            Path=IsChecked, 
            Mode=TwoWay, 
            UpdateSourceTrigger=PropertyChanged}">
         <Border Background="Transparent" Name="Border" Visibility="Visible">
            <ContentControl x:Name="ContentControl" userInterface:RegionHelper.RegionName="{Binding RegionId}" Style="{StaticResource PopupContentStyle}" />
         </Border>
      </Popup>
   </Grid>
   <DataTemplate.Triggers>
      <Trigger SourceName="ContentControl" Property="Content" Value="{x:Null}">
         <Setter TargetName="ContextActionPopup" Property="IsOpen" Value="False" />
      </Trigger>
   </DataTemplate.Triggers>

Everything works fine (my popup and my toggle button do work together as they should) But if I set the value of the Trigger of my DataTemplate (which is done by my business logic, or more specific by some "NavigationService") the Popup gets closed while the ToggleButton stays checked.

Why does my Trigger not change the IsChecked Property of my ToggleButton as well?

Sheridan Sheridan · Accepted Answer · 2015-06-15T15:21:45

Your answer can be found in the Dependency Property Value Precedence page on MSDN. In short, you have set a local value on the IsOpen property and that has a higher precedence than the value set by the Trigger. The solution is to not set the local value, but to set the initial value in a Style instead, which has a lower precedence than the Trigger.

From the linked page on MSDN:

The following is the definitive order that the property system uses when assigning the run-time values of dependency properties. Highest precedence is listed first. This list expands on some of the generalizations made in the Dependency Properties Overview.

Property system coercion. For details on coercion, see Coercion, Animation, and Base Value later in this topic.

Active animations, or animations with a Hold behavior. In order to have any practical effect, an animation of a property must be able to have precedence over the base (unanimated) value, even if that value was set locally. For details, see Coercion, Animation, and Base Value later in this topic.

Local value. A local value might be set through the convenience of the "wrapper" property, which also equates to setting as an attribute or property element in XAML, or by a call to the SetValue API using a property of a specific instance. If you set a local value by using a binding or a resource, these each act in the precedence as if a direct value was set.

TemplatedParent template properties. An element has a TemplatedParent if it was created as part of a template (a ControlTemplate or DataTemplate). For details on when this applies, see TemplatedParent later in this topic. Within the template, the following precedence applies:

a.Triggers from the TemplatedParent template.

b.Property sets (typically through XAML attributes) in the TemplatedParent template.

Implicit style. Applies only to the Style property. The Style property is filled by any style resource with a key that matches the type of that element. That style resource must exist either in the page or the application; lookup for an implicit style resource does not proceed into the themes.

Style triggers. The triggers within styles from page or application (these styles might be either explicit or implicit styles, but not from the default styles, which have lower precedence).

Template triggers. Any trigger from a template within a style, or a directly applied template.

Style setters. Values from a Setter within styles from page or application.

Default (theme) style. For details on when this applies, and how theme styles relate to the templates within theme styles, see Default (Theme) Styles later in this topic. Within a default style, the following order of precedence applies:

a.Active triggers in the theme style.

b.Setters in the theme style.

Inheritance. A few dependency properties inherit their values from parent element to child elements, such that they need not be set specifically on each element throughout an application. For details see Property Value Inheritance.

Default value from dependency property metadata. Any given dependency property may have a default value as established by the property system registration of that particular property. Also, derived classes that inherit a dependency property have the option to override that metadata (including the default value) on a per-type basis. See Dependency Property Metadata for more information. Because inheritance is checked before default value, for an inherited property, a parent element default value takes precedence over a child element. Consequently, if an inheritable property is not set anywhere, the default value as specified on the root or parent is used instead of the child element default value.

TwoWay Binding is not working if Binding is changed from DataTrigger

1 Answers