How to write init methods of a UIViewController in Swift

Question

I am unable to add init method to the following UIViewController class. I need to write some code in the init method. Do i have to write init(coder) method? Even when I add the coder and decoder methods I still get errors. I also tried using the init method without any parameters but that also does not seem to work.

class ViewController: UIViewController {

    var tap: UITapGestureRecognizer?

    override init(nibName nibNameOrNil: String?, bundle nibBundleOrNil: NSBundle?)   {
        super.init(nibName: nil, bundle: nil)
        tap = UITapGestureRecognizer(target: self, action: Selector("handleTap:"))
    }

...
...
}

If I call the super.init() method without parameters the error is "Must call a designated initializer of super class" and if I pass the parameter nib and bundle then error is "Required initializer init(coder)".

Even when I add init(coder) and init(decoder) it does not work.

Answer 1

I used:

convenience init() {
    self.init(nibName:nil, bundle:nil)
}

Some people suggested:

convenience init(){
    self.init()
}

But this gives you an infinite loop.

Answer 2

All of these answers are half-answers. Some people are experiencing infinite loops in related posts because they are only adding the convenience init() (it recursively calls itself if you don't providing a distinct init() method for it to invoke), while other people are neglecting to extend the superclass. This format combines all the solutions to satisfy the problem completely.

// This allows you to initialise your custom UIViewController without a nib or bundle.
convenience init() {
    self.init(nibName:nil, bundle:nil)
}

// This extends the superclass.
override init(nibName nibNameOrNil: String?, bundle nibBundleOrNil: Bundle?) {
    super.init(nibName: nibNameOrNil, bundle: nibBundleOrNil)
    tap = UITapGestureRecognizer(target: self, action: Selector("handleTap:"))
}

// This is also necessary when extending the superclass.
required init?(coder aDecoder: NSCoder) {
    fatalError("init(coder:) has not been implemented") // or see Roman Sausarnes's answer
}

Edit: Also, if you want to initialise any class properties using parameters passed into your convenience init() method without all the overridden init() methods complaining, then you may set all those properties as implicitly unwrapped optionals, which is a pattern used by Apple themselves.

Answer 3

You need to override the init(nibName:bundle:) initializer, and provide the init(coder:) required initializer, and initialize tap in both of them:

class ViewController: UIViewController {

    var tap: UITapGestureRecognizer?

    override init(nibName nibNameOrNil: String?, bundle nibBundleOrNil: Bundle?)   {
        print("init nibName style")
        super.init(nibName: nibNameOrNil, bundle: nibBundleOrNil)
        tap = UITapGestureRecognizer(target: self, action: Selector("handleTap:"))
    }

    // note slightly new syntax for 2017
    required init?(coder aDecoder: NSCoder) {
        print("init coder style")
        super.init(coder: aDecoder)
        tap = UITapGestureRecognizer(target: self, action: Selector("handleTap:"))
    }
...
...
}

Also, be sure when calling the superclass initializer that you don't just pass nil for the nibName and bundle. You should pass up whatever was passed in.

---

Note that the "convenience init" method mentioned in some answers is only relevant if you are actually "by hand" yourself initializing a view controller. (There are very few situations where you would do that.) If you want to "do something during normal initialization" - so for example create a gesture recognizer or just initialize some variables - the only possible solution is exactly the one given in this answer.

Answer 4

You can just create a convenience initializer instead, convenience initializers don't override the init() instead it just calls it making things easier.

class ViewController: UIViewController {
    var tap: UITapGestureRecognizer?
    convenience init(){
        self.init()
        tap = UITapGestureRecognizer(target: self, action: Selector("handleTap:"))
    }
}

Answer 5

I think you have to add

required init(coder aDecoder: NSCoder) {
    print("init coder")
    super.init(coder: aDecoder)
}

or

convenience init() {
    self.init()
}

You have to write init too. Don't remove it

var tap: UITapGestureRecognizer?

override init(nibName nibNameOrNil: String?, bundle nibBundleOrNil: NSBundle?)   {
    super.init(nibName: nil, bundle: nil)
}

Hope it helps

Answer 6

I came across this Question of You asked long way Back. But no one has provided a basic answer to the question. It's a basic in Swift that:- Subclass must initialize its variables before it's super class initialization is complete.

Hence as Ankit Goel mentioned the crash :- "Must call a designated initializer of superclass"

Hence updated code would be:-

class ViewController: UIViewController {
    var tap: UITapGestureRecognizer?

    override init(nibName nibNameOrNil: String?, bundle nibBundleOrNil: Bundle?)   {
        print("init nibName style")
        self.tap = nil
        super.init(nibName: nibNameOrNil, bundle: nibBundleOrNil)
        self.tap = UITapGestureRecognizer(target: self, action: Selector(("handleTap:")))
    }

    required init?(coder aDecoder: NSCoder) {
        print("init coder style")
        self.tap = nil
        super.init(coder: aDecoder)
        tap = UITapGestureRecognizer(target: self, action: Selector(("handleTap:")))
    }
}

Answer 7

I was facing the same issue with Swift 5 in Xcode 12.0 and this is my solution in 2020.

class Foo: UIViewController {
    private var bar: Bar!

    override init(nibName nibNameOrNil: String?, bundle nibBundleOrNil: Bundle?) {
        super.init(nibName: nibNameOrNil, bundle: nibBundleOrNil)

        setupController()
    }

    required init?(coder aDecoder: NSCoder) {
        super.init(coder: aDecoder)

        setupController()
    }
    
    private func setupController() {
        bar = Bar()
    }
}

and an alternative I am using is to do the initialization inside loadView function.

class Foo: UIViewController {
    private var bar: Bar!
    
    override func loadView() {
        setupController()
    }

    private func setupController() {
        bar = Bar()
    }
}

Answer 8

Correct flow is, call the designated initializer which in this case is the init with nibName,

init(tap: UITapGestureRecognizer)
{
    // Initialise the variables
    tap = UITapGestureRecognizer(target: self, action: Selector(("handleTap:")))

    // Call the designated init of ViewController
    super.init(nibName: nil, bundle: nil)

    // Call your viewcontroller custom methods here
    setupViewControllers()
}