Obj-C: calling release/dealloc causes EXC_BAD_ACCESS

Question

Here is my custom class:

PolygonShape : NSObject {
 int numberOfSides;
 int minimumNumberOfSides;
 int maximumNumberOfSides;
}

My custom init method:

- (id)initWithNumberOfSides:(int)sides minimumNumberOfSides:(int)min maximumNumberOfSides:(int)max {
 if (self = [super init]) { 
  [self setMinimumNumberOfSides:min];
  [self setMaximumNumberOfSides:max];
  [self setNumberOfSides:sides];
 } 

 return self;
}

My dealloc method:

- (void) dealloc {
 NSLog("Calling dealloc");
 [super dealloc];
}

My sample code that crashes:

  PolygonShape *shape1 = [[PolygonShape alloc] initWithNumberOfSides:6 minimumNumberOfSides:5 maximumNumberOfSides:9];
 [shape1 release];

I've alloc-ed a PolygonShape increasing the retain count by 1 and then release-ing should decrement it to 0 and call dealloc, printing that message to NSLog but I just get EXC_BAD_ACESS. I'm able to access and change the fields in my object after creating it so everything up until there works. Many thanks for the help!

have you a proper autorelease pool? (the only idea I have currently!) — ShinTakezou
Don't forget to check dreamlax's posting as the correct answer. — Lyndsey Ferguson

dreamlax dreamlax · Accepted Answer · 2010-06-10T21:24:14

NSLog("Calling dealloc");

You are passing a regular C string, rather than an NSString. You need to do this:

NSLog(@"Calling dealloc");

Your compiler should have warned you about passing an incompatible pointer.

Obj-C: calling release/dealloc causes EXC_BAD_ACCESS

3 Answers