Do we need to use __weak self inside UIAnimationBlocks in ARC?

27
votes

Do we need to use __weak self inside UIAnimation Blocks as given below? Whether it will create retain cycle issue if we are not specifying self as weak?

[UIView animateWithDuration:animationDuration 
                      delay:0 
                    options:UIViewAnimationCurveEaseInOut 
                 animations:^{
        [self doSomething];
    } completion:^(BOOL finished) {
        if (finished) {
            [self doSomething];
        }
    }];

I am also confused in the following scenario. Any thoughts on this? please share your comments.

[self.navController dismissViewControllerAnimated:animated 
                                       completion:^{
                                                      [self doSomething];
                                                  }];

Should we use weak self here?

3
iosautomatic-ref-countingobjective-c-blocksretain-cycle
Thank you guys, I am getting clearer and clearer. I would like to discuss the following case as well. [self.navController dismissViewControllerAnimated:animated completion:^{ [self doSomething]; }]; – arango_86

3 Answers

61
votes

This is not a retain cycle. A retain cycle would be

self -> block -> self

In this case we have

animation framework -> block
block -> self

where the first retain is only temporary - the block gets released when the animation ends. Even if a retain cycle happens, it will be only temporary and it won't prevent object deallocation.

6
votes

You need to use __weak when retain cycle is possible. This is not that case because animations block is not retained by self.

Another situation to use __weak is a prolonged action that will call our block after completion and self can be deallocated during this action. For example, some network request will call interface update for our view controller in completion block. User can exit our screen during request. In this situation no need to retain self with a block, it's better to use weak self. But using animation blocks is not this situation too.

2
votes

No, it won't create a retain cycle, because the block (closure) is not attached to self.
For more information, please check out Apple's Automatic Reference Counting.