Undefined method 'id' for nil:NilClass

1
votes

I am having trouble solving this problem. I keep getting the same error: ActionView::Template::Error (undefined method `id' for nil:NilClass):

Here is my likes controller: 

class LikesController < ApplicationController

def new
  @bookmark = Bookmark.find(params[:bookmark_id])
  @like = Like.new
end

  def create
    @bookmark = Bookmark.find(params[:bookmark_id])
    # @like = Like.new
    # @like.user = current_user
    # @like.bookmark = @bookmark
    @like = current_user.likes.build(bookmark: @bookmark)

    if @like.save
      flash[:notice] = "Bookmark was Liked!"
      redirect_to @bookmark
    else
      flash[:error] = "Unable to Like Bookmark"
      redirect_to @bookmark
    end
  end

  def destroy
    #@bookmark = Bookmark.find(params[:bookmark_id])
    @like = @bookmark.likes.find(params[:id])

    if @like.destroy
      flash[:notice] = "Bookmark was Un-liked."
      redirect_to @bookmark
    else
      flash[:error] = "Error Un-liking bookmark."
      redirect_to @bookmark
    end
  end

end

My User model: 

class User < ActiveRecord::Base
  devise :database_authenticatable, :registerable,
         :recoverable, :rememberable, :trackable, :validatable, :confirmable

  has_many :topics
  has_many :bookmarks
  has_many :likes, dependent: :destroy

  def liked(bookmark)
    likes.where(bookmark: bookmark.id).first
  end
end

My likes partial: 

 <div>
  <% if like = current_user.liked(bookmark) %>
    <%= link_to [@topic, bookmark, like], class: 'btn btn-danger', method: :delete do %>
      <i class="glyphicon glyphicon-star-empty"> </i>&nbsp; Unlike
      <% end %>
    <% else %>
      <%= link_to [@topic, bookmark, Like.new], class: 'btn btn-primary', method: :post do %>
        <i class="glyphicon glyphicon-star"> </i>&nbsp; Like
      <% end %>
    <% end %>
  </div>

Let me know if I need to show anything else, I appreciate any help

2
ruby-on-rails
which action gave you the error? which line is the error pointing to? - jpriebe
The error is pointing to: <div> <% if like = current_user.liked(bookmark) %> <%= link_to [@topic, bookmark, like], class: 'btn btn-danger', method: :delete do %> <i class="glyphicon glyphicon-star-empty"> </i>&nbsp; Unlike <% end %> - Jenny Crawshaw
Specifically to the line <% if like = current_user.liked(bookmark) %> - Jenny Crawshaw
In my rails console, if I pull up a Bookmark, it looks like this: => #<Bookmark id: 1, url: "http://localhost:3000/topics/11/bookmarks/new", topi c_id: 11, created_at: "2015-02-17 19:28:17", updated_at: "2015-02-17 19:28:17", user_id: 1, bookmark_id: nil> 2.0.0-p481 :003 > So there is a bookmark id at the beginning, but it is still showing nil for the bookmark_id? - Jenny Crawshaw
try changing your liked function in users.rb to Like.where(bookmark: bookmark.id).first - jpriebe

2 Answers

2
votes

From where you are calling the partial try this :

<% @bookmarks.each do |bookmark| %> 
  <%= render partial: 'likes/like', locals: {bookmark: bookmark} %> 
<% end %>
0
votes

In your likes partial, you have:

<% if like = current_user.liked(bookmark) %>

That = should be a ==. With a single equals, you're checking whether the like variable is assigned a truthy value, based on current_user.liked(bookmark). You want a double equals to test equality.

UPDATE If you really mean to both assign and compare, split it into two lines so it looks like it's intentional. It's a microexample of the "Command / Query Separation Principle."

<% like = current_user.liked(bookmark) %>
<% if like %>

(Sorry this probably doesn't relate directly to your question, but it was very distracting to see.)