Does DBCP connection pool connection.close() return connection to pool

Question

Using BasicDataSource from DBCP if we do a getConnection() and in the finally block we close the connection does it really return the connection to the pool or does it close the connection. The snippet code I am checking is this

try {
        Connection conn1 = getJdbcTemplate().getDataSource()
                .getConnection();
        //Some code to call stored proc 

    } catch (SQLException sqlEx) {
        throw sqlEx;
    } finally {
        try {
            if (conn != null) {
                conn.close();
            }
        } catch (SQLException ex1) {
            throw ex1;
        }

    }

I was checking the source code of BasicDataSource and I reached this wrapper class for the connection.

private class PoolGuardConnectionWrapper extends DelegatingConnection {

    private Connection delegate;

    PoolGuardConnectionWrapper(Connection delegate) {
        super(delegate);
        this.delegate = delegate;
    }

    public void close() throws SQLException {
        if (delegate != null) {
            this.delegate.close();
            this.delegate = null;
            super.setDelegate(null);
        }
    }

The delegate object if of type java.sql.Connection. The wrapper code calls the close method of the delegate which will close the collection rather than returning the connection to pool. Is this a known issue with DBCP or am I reading the source code incorrectly please let me know.

Thanks

If I don't close the connection the pool throws an error after the maxActive Limit is reached. I am just checking this because I read that if we close a connection in connectionpool, the connection wrapper instead of closing the connection puts it back in the pool. But from source code I cannot infer the same — Pratik Shelar

nos nos · Accepted Answer · 2015-01-29T09:30:44

6

votes

You'll end up calling PoolableConnection.close(), which returns it to the pool.

Does DBCP connection pool connection.close() return connection to pool

1 Answers