Cant upload and store the image to the database by using php

Question

I try to build an upload image system by using php.After testing it,the system echo out"Image is uploaded",but it doesn't shown in database.Here is my code here

upload.php

<?php
//connect database
include('config.php');

//file properties
 if(isset($_FILES['image'])){
   $file = $_FILES['image']['tmp_name'];
}

if(!isset($file)){
    echo "Please select an image";
}
else{
    $image = addslashes(file_get_contents($_FILES['image']['tmp_name']));
    $image_name =addslashes($_FILES['image']['name']);
    $image_size =getimagesize($_FILES['image']['tmp_name']);

    if ($image_size == FALSE) {
        echo "This is not an image";
    }
    else{
        $insert = "INSERT INTO image(name,picture) VALUES ('$image_name','$image')";

        if(!$insert){
            echo "Problem uploading";
        }
        else {
            $lastid =mysqli_insert_id($con);
            echo "Image Uploaded <p />Your Image :<p /><img src=get.php?id=$lastid>";
        }
    }
}


?>

get.php

<?php
include ('config.php');

$id = addslashes($_REQUEST['id']);

$image = mysqli_query($con ,"SELECT * FROM image WHERE id=$id");
$image = mysqli_fetch_assoc($image);
$image = $image['picture'];

header("Content-type :image/jpeg");
?>

and I clicking the submit button without choosing any files this 2 line of warning is showing up

Warning: file_get_contents(): Filename cannot be empty in upload.php line 14.

line14 is this $image = addslashes(file_get_contents($_FILES['image']['tmp_name']));

Warning: getimagesize(): Filename cannot be empty in in upload.php line 16.

while line 16 is this $image = addslashes(file_get_contents($_FILES['image']['tmp_name']));

Any idea about this?

Why are you wanting to put images in the database to begin with? — Mike Brant
I mean that, generally speaking, storing images in a database, rather than a file system reference to an image, is a bad application design. Unless you are doing binary searches on the images themselves or something like that, you are probably saddling yourself with a bad architecture. — Mike Brant
@MikeBrant mike,any reference for me to do the file system reference that you mention??any reference that provided is well-appreciated..Cause i am a very beginner in php languages..tq — ken
Just look back the question I ask,now I understand what you mean.thanks..haha — ken

kos kos · Accepted Answer · 2014-12-21T17:47:30

You need a function to send your query, otherwise you just filled up a string: this:

$insert = "INSERT INTO image(name,picture) VALUES ('$image_name','$image')";

should be followed by this:

mysqli_query($con, $insert);

The warnings are caused by multiple issues with your code. First you are checking whether the file has been uploaded in the wrong way: this

if(isset($_FILES['image'])){
    $file = $_FILES['image']['tmp_name'];
}

Will always set a $file variable, even though no file has been selected into the form, leading therefore to never execute this if statement:

if(!isset($file)){
    echo "Please select an image";
}

and to always execute what's in the else block instead, which causes the errors, because the functions you mentioned, which are contained in this else block, are not able to operate on any file.

Therefore simply checking the file upload correctly will solve the issue: one way to do this would be to first remove this, which is unuseful

if(isset($_FILES['image'])){
    $file = $_FILES['image']['tmp_name'];
}

and then change this:

if(!isset($file)){
    echo "Please select an image";
}

to this:

if(!isset($_FILES['image']['tmp_name'])){
    echo "Please select an image";
}

Cant upload and store the image to the database by using php

2 Answers