0
votes

First of all, I realized through my search that this has been asked a thousand times before, so sorry, but I was having trouble interpreting the answers. I'm very new to ActionScript 3 and only a novice programmer in general.

So I'm programming a simple game where some balls move and accelerate around. However, whenever I call my collision checking function (isWithin), it gives Error #1006: Value is not a function. Am I calling or declaring the function incorrectly?

import flash.ui.Keyboard;
import flash.events.Event;
import flash.events.KeyboardEvent;
import flash.text.TextField;
import flash.text.TextFormat;

// add the event listeners
PlayerBall.addEventListener(Event.ENTER_FRAME, update);
stage.addEventListener(KeyboardEvent.KEY_DOWN, onKeyDown);
stage.addEventListener(KeyboardEvent.KEY_UP, onKeyUp);

// this array holds references to all the keys

var keys:Array = [];

var xSpeed1:Number = 0;
var ySpeed1:Number = 0;

var xSpeed2:Number = 0;
var ySpeed2:Number = 0;

var hasFlag:int = 0;

var collide:Boolean = false;

function isWithin(object1:Object, object2:Object, barrier:Number):Boolean
{
var distance:Number = Math.sqrt((object1.x - object2.x)(object1.x - object2.x) + (object1.y - object2.y)(object1.y - object2.y));

if(distance <= barrier)
{
    return(true);
}
else
{
    return(false);
}
}

collide = isWithin(PlayerBall, PlayerBall2, PlayerBall.width);
trace(collide);

function update(e:Event):void
{

// GETTING KEYBOARD INPUT FOR FRAME
if(keys[Keyboard.UP])
{
    ySpeed1 = ySpeed1 < -5 ? ySpeed1 : ySpeed1 - .3;
}
if(keys[Keyboard.DOWN])
{
    ySpeed1 = ySpeed1 > 5 ? ySpeed1 : ySpeed1 + .3;
}
if(!(keys[Keyboard.UP]) && !(keys[Keyboard.DOWN]))
{
    ySpeed1 = ySpeed1 > 0 ? ySpeed1 - .2 : ySpeed1 + .2;
}


if(keys[Keyboard.RIGHT])
{
    xSpeed1 = xSpeed1 > 5 ? xSpeed1 : xSpeed1 + .3;
}
if(keys[Keyboard.LEFT])
{
    xSpeed1 = xSpeed1 < -5 ? xSpeed1 : xSpeed1 - .3;
}
if(!(keys[Keyboard.RIGHT]) && !(keys[Keyboard.LEFT]))
{
    xSpeed1 = xSpeed1 > 0 ? xSpeed1 - .2 : xSpeed1 + .2;
}

if(keys[Keyboard.W])
{
    ySpeed2 = ySpeed2 < -5 ? ySpeed2 : ySpeed2 - .3;
}
if(keys[Keyboard.S])
{
    ySpeed2 = ySpeed2 > 5 ? ySpeed2 : ySpeed2 + .3;
}
if(!(keys[Keyboard.W]) && !(keys[Keyboard.S]))
{
    ySpeed2 = ySpeed2 > 0 ? ySpeed2 - .2 : ySpeed2 + .2;
}


if(keys[Keyboard.D])
{
    xSpeed2 = xSpeed2 > 5 ? xSpeed2 : xSpeed2 + .3;
}
if(keys[Keyboard.A])
{
    xSpeed2 = xSpeed2 < -5 ? xSpeed2 : xSpeed2 - .3;
}
if(!(keys[Keyboard.A]) && !(keys[Keyboard.D]))
{
    xSpeed2 = xSpeed2 > 0 ? xSpeed2 - .2 : xSpeed2 + .2;
}

// MOVEMENT

PlayerBall.x += xSpeed1;
PlayerBall.y += ySpeed1;

PlayerBall2.x += xSpeed2;
PlayerBall2.y += ySpeed2;

if(hasFlag == 1)
{
    flag.x = PlayerBall.x;
    flag.y = PlayerBall.y;
}
if(hasFlag == 2)
{
    flag.x = PlayerBall2.x;
    flag.y = PlayerBall2.y
}

// COLLISION CHECKING

collide = isWithin(PlayerBall, flag, PlayerBall.width/2 + flag.width/2);

if(flag.visible && collide)
{
    hasFlag = 1;
    flag.visible = false;

    flag.x = PlayerBall.x;
    flag.y = PlayerBall.y;
}

collide = isWithin(PlayerBall2, flag, (PlayerBall2.width/2 + flag.width/2));

if(flag.visible && collide)
{
    hasFlag = 2;
    flag.visible = false;

    flag.x = PlayerBall2.x;
    flag.y = PlayerBall2.y;
}
}

function onKeyDown(e:KeyboardEvent):void
{
    keys[e.keyCode] = true;
}

function onKeyUp(e:KeyboardEvent):void
{
keys[e.keyCode] = false;
}
2

2 Answers

0
votes

You're missing multiplication operators. Please change row

var distance:Number = Math.sqrt((object1.x - object2.x)(object1.x - object2.x) + (object1.y - object2.y)(object1.y - object2.y));

to

var distance:Number = Math.sqrt((object1.x - object2.x)*(object1.x - object2.x) + (object1.y - object2.y)*(object1.y - object2.y));
0
votes

Well, I can see a problem in you 'var distance' calculation. If you mean to multiply the bracketed subtraction values, you should put a '*' between the end and start brackets of each pair, ie:

var distance:Number = Math.sqrt((object1.x - object2.x)*(object1.x - object2.x) + (object1.y - object2.y)*(object1.y - object2.y));

You are getting that particular error, I'm guessing, because the compiler is interpreting the second set of brackets in each pair as containing parameters for a function. Hence 'value is not a function'.