Nodes in binary tree are null

Question

void MultiMap::insert(string key, unsigned int value)
{
    if(head == nullptr)
        head = new Node(key, value);
    else
    {
        Node* tempNode = head;
        while(tempNode != nullptr)
        {
            if(key <= tempNode->m_key)
                tempNode = tempNode->m_left;
            else if(key > tempNode->m_key)
                tempNode = tempNode->m_right;
        }
        /*line 1*/tempNode = new Node(key, value);
        //*line 2*/head->m_left = new Node(key, value);
    }
}

For an assignment, I have to make a binary tree class, "MultiMap" with nodes that contain a string and an int.

The above is code to insert a new node into the tree. The nodes are sorted by their strings. If the string of the node I am trying to insert is > the current node, the program should try to insert it on the right branch of the tree, and if it is <=, the program should try to insert it on the left branch of the tree.

I tested it by trying to insert two nodes: (Joe, 5) and (Bill, 1) in that order, so if the program works properly, "bill" should be on the left branch of "joe".

Line 2 is commented out.

If I use line 1, the program compiles and "inserts" the second node, but when I try to look for it with other code, it only finds a nullptr. If I replace line 1 with line 2, the program works as expected.

"tempNode" is what I'm using to trace through the tree to find the appropriate place to insert a new node. "head" is a pointer to the first node in the tree. "m_left" and "m_right" are pointers to nodes, representing the left and right branches of a node, respectively.

I don't know why the two lines don't do the same thing even though at that point, it seems like tempNode and head->m_left are pointing to the same location in memory: the left branch of the first node.

Your line 2 comment is confusing me... I would recommend // /*. — PlasmaPower
it seems like tempNode and head->m_left are pointing to the same location in memory: Well, did using the debugger confirm this? — PaulMcKenzie
if I use line 1, the program compiles and "inserts" the second node Having a program compile means nothing except that the code is syntactically correct -- it doesn't mean that the program will do what you want it to do at runtime. Please use the debugger to debug your program instead of guessing what should happen. — PaulMcKenzie
I did use the debugger and it executed the line that says: /*line 1*/tempNode = new Node(key, value); that's what I meant by "insert". — gallardoelise

WhozCraig WhozCraig · Accepted Answer · 2014-03-09T04:30:28

Pointers are variables that hold addresses. There is nothing magic about them. Line 1 does this:

tempNode = new Node(key, value);

This doesn't insert anything into your tree. In fact, it just leaks memory.

What tempNode pointed to prior to this statement is irrelevant. More importantly, how tempNode held that prior value is already lost because you're already descended down the tree one level. Two pointers holding the same address just means the address is reachable with two pointers. Assigning a new address to a pointer has no effect on the previously addressed entity (if there was any).

Your task should be finding the pointer that should be filled in with the address of a newly allocated object. You found it (sort of). Unfortunately you also lost it as soon as you walked into it with your step "down" the tree for the final null-detection. As soon as this:

while (tempNode != nullptr)

becomes false and breaks, you're already one node too far. There are a number of ways to handle this. Some people like using a "parent" pointer, but that just means you have to special-case an empty map condition. Consider this instead:

void MultiMap::insert(string key, unsigned int value)
{
    // pp will always point to the pointer we're testing
    //  i.e. a pointer to pointer.
    Node **pp = &head;

    while (*pp) // while whatever pp points to is a non-null-pointer
    {
        if (key < (*pp)->m_key)
            pp = &(*pp)->m_left; // put address of left-pointer into pp

        else if ((*pp)->m_key < key)
            pp = &(*pp)->m_right; // put address of right pointer into pp

        else break; // strict weak order match 
    }

    if (*pp)
    {
        // found matching key. NOTE: unclear if you wanted to just update or not
    }
    else
    {
        // allocate new node.
        *pp = new Node(key,value);
    }
}

And you'll notice other than initializing our pointer-to-pointer with the address of the head node pointer, head is never referenced again.

Finally, notice there is no special-case head-node test. If the map is empty and the head pointer is NULL, this will automatically create a new node and make it the root.

Nodes in binary tree are null

2 Answers