21
votes

I just spent a fair amount of time finding a 64-bit installation of pygame to use with python 3.3, (here) and now am trying to make a window. However, although the window opens up fine it does not close when it hit the x button. In fact, I have to close IDLE to close the window. I am running a 64 bit version of Win 7. Here is my code:

import pygame
import time
(width, height) = (300, 200)
screen = pygame.display.set_mode((width, height))
pygame.display.flip()
pygame.display.set_caption("Hello World")
running = True
while running:
    for event in pygame.event.get():
        if event.type == pygame.QUIT:
            running = False

When I append

time.sleep(5)
pygame.quit()

It still doesn't close. My only guess would be that pygame.quit might go inside one of the loops, but even if that were resolved I would greatly prefer being able to close the window when I want to.

9
Try running the code from command prompt and see if the problem persist - xor
what pygame version are you using? - Alfgaar
@Alfgaar To be honest, I don't remember. It was a while ago :) - KnightOfNi

9 Answers

26
votes

Most pygame tutorials seem to suggest exiting by calling pygame.quit() and then sys.exit(). I have personally run into problems (was on a unix system though) where this still did not close the window properly. The solution was to add pygame.display.quit() specifically before pygame.quit(). That should not be necessary as far as I can tell, and I'm afraid I don't know why that solved the issue but it did.

16
votes

if you want to make pygame close when window button x is pressed, put the code like this:

from sys import exit
while True:
        for event in pygame.event.get():
            if event.type == pygame.QUIT:
                pygame.quit()
                exit()

We put exit() after pygame.quit(), because pygame.quit() makes the system exit and exit() closes that window.

6
votes

Not sure but try this Because you code runs fine on my system after I add pygame.quit() at the end

import pygame
import time
(width, height) = (300, 200)
screen = pygame.display.set_mode((width, height))
pygame.display.flip()
pygame.display.set_caption("Hello World")
running = True
try:
    while running:
        for event in pygame.event.get():
            if event.type == pygame.QUIT:
                running = False
    pygame.quit()
except SystemExit:
    pygame.quit()

Its perhaps because as Idle is made on Tkinter and thus Tkinter and Pygame main loop do not have a mutual understanding.
Your code will run very well on command prompt though.

3
votes

This was the final code that worked for me on OSX whilst keeping the kernel alive on Jupyter. EDIT - it does still crash the kernel sometimes :-(

running = True
while running:
    for event in pygame.event.get():
        if event.type == pygame.QUIT:
            running = False
pygame.display.quit()
pygame.quit()
exit()

Also needed to downgrade ipython to get rid of some magic alias warning messages using:

conda install ipython=7.2.0

apparently that issue is due to be fixed in ipython 7.6.0

1
votes

Suffered the same issues on Python 3.7.4 while running it from in IDE (Spyder 3.3.6). In my case the pygame.quit() would not completely close the program. Nonetheless, adding quit() or exit() did the trick for me!

1
votes

Add this at the top:

import sys

Add this where you need to quit:

if event.type == pygame.QUIT:
    pygame.quit()
    sys.exit()
0
votes

try using the following command:

sys.exit(0)

notice: You will need to import the sys library in order to use it.

0
votes

The IDE interferes with how pygame runs the code. Try to run it from the commandline or the terminal. The problem should disappear.

-2
votes

To answer the original question: You must call pygame.quit() after breaking the main loop. One elegant solution goes as follows:

def run():
    pygame.init()
    while True:
        # ...
        for event in pygame.event.get():
            # Handle other events
            if event.type == pygame.QUIT:
                return pygame.quit()