Struts 2 type converter issue

Question

I am trying to use custom type conversion with property file for action.

Action class is implementing ModelDriven for bean properties.

public class WelcomeAction extends ActionSupport implements ModelDriven<MyBean>{

public String execute(){
    return SUCCESS;
}

private MyBean bean = new MyBean();

@Override
public MyBean getModel() {
    return bean;
}
}

Bean class is:

public class MyBean{

private Rectangle rectangle;
public Rectangle getRectangle() {
    return rectangle;
}

public void setRectangle(Rectangle rectangle) {
    this.rectangle = rectangle;
}

}

and I have WelcomeAction-conversion.properties file parallel to action class with converter config as:

bean.rectangle=struts2.typeconverters.RectangleTypeConverter

I tried putting key as bean, rectangle etc but its not working, its not using converter class.

If i use @TypeConverter annotation or global converter then its working fine.

My struts 2 version is 2.3.15.1, any idea what could be the issue.

UPDATE: Created an issue https://issues.apache.org/jira/browse/WW-4249

Got the correct way for implementation: http://www.journaldev.com/2221/struts-2-ognl-tutorial-with-custom-type-converter-example

Have you tried this rectangle=struts2.typeconverters.RectangleTypeConverter? — Lukasz Lenart
yes I tried that too, its not working. I posted here only when I am out of options. — Pankaj
Not sure it is possible for model driven with conversion applied to action. You can apply converter to a bean or globally. — Aleksandr M
I am having the same problem with the same struts version. It is probably a bug with this Struts version. — Manu
@Pankaj: Because the model is on the top of the stack the conversion applied to action doesn't take effect. Not a bug. — Aleksandr M

Bruce Phillips Bruce Phillips · Accepted Answer · 2013-11-29T14:06:55

If your Action class is using Model Driven then you need to follow this methodology for custom type convertor:

http://struts.apache.org/release/2.3.x/docs/type-conversion.html (see section titled Applying a Type Converter to a bean or model).

In your example I changed the conversion properties file name to MyJavaBean-conversion.properties and placed it under the same package as the MyJavaBean.java.

In MyJavaBean-conversion.properties I changed the key to:

      rectangle=com.journaldev.struts2.typeconverters.RectangleTypeConverter

I then built the .war file and ran your example under Tomcat 7. The rectangle conversion worked correctly.

I don't think you could ever use the methodology explained at http://struts.apache.org/release/2.3.x/docs/type-conversion.html (see section titled Applying a Type Converter to an Action) when your Action class is using ModelDriven. If you find a previous Struts 2 version where that did work let me know.

Bruce Phillips

Struts 2 type converter issue

3 Answers