how to use fileset in ant macrodef

Question

I would like to use the fileset in below macrodef.

I wish to change attribute jar to dir so that all jar files in dir can be processed.

<macrodef name="unjartemp">
    <attribute name="jar" />
    <sequential>
        <!-- Remove any existing signatures from a JAR file. -->
        <tempfile prefix="unjar-" 
        destdir="${java.io.tmpdir}" property="temp.file" />
        <echo message="Removing signatures from JAR: @{jar}" />
        <mkdir dir="${temp.file}" />
        <unjar src="@{jar}" dest="${temp.file}" />    
        <delete file="@{jar}" failonerror="true" />
    </sequential>
</macrodef>

Answer 1

To keep it flexible you may use macrodef with nested element attribute for 1-n filesets, f.e.
a macrodef that creates a dirlisting in xmlformat for nested filesets :

<macrodef name="dir2xml">
 <attribute name="file"
  description="xmlfile for filelisting"/>
 <attribute name="roottag"
  description="xml root tag"/>
 <attribute name="entrytag"
  description="xml tag for entry"/>
 <element name="fs"
  description="nested filesets for listing"/>
 <sequential>
  <pathconvert
   property="files.xml"
   dirsep="/"
   pathsep="&lt;/@{entrytag}&gt;${line.separator} &lt;@{entrytag}&gt;"
  >
   <!-- 1-n nested fileset(s) -->
   <fs/>
  </pathconvert>
  <!-- create xmlfile -->
  <echo message="&lt;@{roottag}&gt;${line.separator} &lt;@{entrytag}&gt;${files.xml}&lt;/@{entrytag}&gt;${line.separator}&lt;/@{roottag}&gt;" file="@{file}"/>
  </sequential>
</macrodef>

Usage :

<dir2xml file="filelistant.xml" entrytag="antfile" roottag="antfilelist">
 <fs>
  <fileset dir="." includes="**/*.xml"/>
  <fileset dir="../ant_xml" includes="**/*.xml"/>
 </fs>
</dir2xml>

Answer 2

Add your fileset:

<fileset dir="${jars.dir}" id="jars_to_unjar">
    <include name="**/*.jar"/>
</fileset>

call you macros:

<unjartemp filesetref="jars_to_unjar"/>

And you can try this modified macros:

<macrodef name="unjartemp">
    <attribute name="filesetref" />
    <sequential>
        <for param="file">
            <fileset  refid="@{filesetref}"/>
            <sequential>
                <!-- Remove any existing signatures from a JAR file. -->
                <tempfile prefix="unjar-" 
                destdir="${java.io.tmpdir}" property="temp.file" />
                <echo message="Removing signatures from JAR: @{file}" />
                <mkdir dir="${temp.file}" />
                <unjar src="@{file}" dest="${temp.file}" />    
                <delete file="@{file}" failonerror="true" />
            </sequential>
        </for>
    </sequential>
</macrodef>