47
votes

I have a header file suppose abc.h, where i have function declaration as:

static int function1();

I have included this header file in abc.c and has defined the function and used it.

static int function1()
{
 < function definition>
}

After compiling I am getting warning:

warning: function1 declared static but never defined

How can I remove warning, without removing static. Thanks.

2
Move the forward declaration from the header to your source file ? - simonc
If a function is static, you're not supposed to put it in a header file (unless inline)... - user529758
@H2CO3 or private header - SomeWittyUsername
Remove the static keyword from function definition - it's redundant there. Though this should've worked anyway - I suppose the problem is elsewhere. - SomeWittyUsername
Also be careful about the () in C. In a declaration this means that the function may receive any type of arguments. In particular this is not considered to be a prototype of the function. For the definition it means a function that does receive no parameter at all. In C you should always use (void) instead. - Jens Gustedt

2 Answers

49
votes

A static function can be declared in a header file, but this would cause each source file that included the header file to have its own private copy of the function, which is probably not what was intended.

Are u sure u haven't included the abc.h file in any other .c files?

Because declaring a function as static, requires the function to be defined in all .c file(s) in which it is included.

13
votes

Good practice: Declare static functions in the source file they are defined in (please also provide prototype), since that's the only file they are visible in.

This way, the function is only visible to that file, such visibility issues can reduce possible code conflict! So, just provide the prototype and the static function definition in the .c file. Do not include the static function in the header file; the .h file is for external consumption.

Duplicate: Static functions in C