28
votes

I've noticed that sometimes wrapper scripts will use ${1:+"$@"} for the parameters rather than just "$@".

For example, http://svn.macosforge.org/repository/macports/trunk/dports/editors/vim-app/files/gvim.sh uses

exec "$binary" $opts ${1:+"$@"}

Can anyone break ${1:+"$@"} down into English and explain why it would be an advantage over plain "$@"?

3

3 Answers

26
votes

'Hysterical Raisins', aka Historical Reasons.

The explanation from JesperE (or the Bash man page on shell parameter expansion) is accurate for what it does:

  • If $1 exists and is not an empty string, then substitute the quoted list of arguments.

Once upon 20 or so years ago, some broken minor variants of the Bourne Shell substituted an empty string "" for "$@" if there were no arguments, instead of the correct, current behaviour of substituting nothing. Whether any such systems are still in use is open to debate.

[Hmm: that expansion would not work correctly for:

command '' arg2 arg3 ...

In this context, the correct notation is:

${1+"$@"}

This works correctly whether $1 is an empty argument or not. So, someone remembered the notation incorrectly, accidentally introducing a bug.]

3
votes

To quote the relevant portion of man bash for the information that Jonathan Leffler referred to in his comment:

When not performing substring expansion, bash tests for a parameter that is unset or null; omitting the colon results in a test only for a parameter that is unset.

(emphasis mine)

3
votes

From the bash man page:

   ${parameter:+word}
          Use Alternate Value.  If parameter is null or unset, nothing  is
          substituted, otherwise the expansion of word is substituted.

So, "$@" is substituted unless $1 is unset. I can't see why they couldn't have just used "$@".