275
votes

I have a constructor that takes some arguments. I had assumed that they were constructed in the order listed, but in one case it appears they were being constructed in reverse resulting in an abort. When I reversed the arguments the program stopped aborting. This is an example of the syntax I'm using. The thing is, a_ needs to be initialized before b_ in this case. Can you guarantee the order of construction?

e.g.

class A
{
  public:
    A(OtherClass o, string x, int y) :
      a_(o), b_(a_, x, y) { }

    OtherClass a_;
    AnotherClass b_;
};
3
You say you're asking about constructor arguments, but they're evaluated before you ever reach the constructor, and they're evaluated in an unspecified, compiler-determined order. But you're really asking about the order of initialization lists, so I've changed the question title for you.Rob Kennedy
I was asked this question in an interview :)Sunil Kartikey
The interviewer probably got the question from here :)hookenz

3 Answers

306
votes

It depends on the order of member variable declaration in the class. So a_ will be the first one, then b_ will be the second one in your example.

209
votes

To quote the standard, for clarification:

12.6.2.5

Initialization shall proceed in the following order:

...

  • Then, nonstatic data members shall be initialized in the order they were declared in the class definition (again regardless of the order of the mem-initializers).

...

24
votes

The standard reference for this now appears to be 12.6.2 section 13.3:

(13.3) — Then, non-static data members are initialized in the order they were declared in the class definition (again regardless of the order of the mem-initializers).