0
votes

I'm new to VHDL and I'm getting the following error when I try to compile my code:

Error (10517): VHDL type mismatch error at vga_controller.vhd(60): std_logic type does not match integer literal Error (10327): VHDL error at vga_controller.vhd(60): can't determine definition of operator ""-"" -- found 0 possible definitions

Seem the problem is the h_count, before I set to STD_lOGIC i set it to INTEGER and it complain as follow:

Error (10476): VHDL error at vga_controller.vhd(104): type of identifier "h_count" does not agree with its usage as "std_logic_vector" type

Therefore I change it to STD_LOGIC but it just give me another error message.

LIBRARY ieee;
USE ieee.std_logic_1164.all;
USE ieee.numeric_std.all;

ENTITY vga_controller IS
GENERIC(
h_pulse     :   INTEGER := 128;     --horiztonal sync pulse width in pixels
    h_bp        :   INTEGER := 88;      --horiztonal back porch width in pixels
    h_pixels    :   INTEGER := 800;     --horiztonal display width in pixels
    h_fp        :   INTEGER := 40;      --horiztonal front porch width in pixels
    h_pol       :   STD_LOGIC := '1';       --horizontal sync pulse polarity (1 = positive, 0 = negative)
    v_pulse     :   INTEGER := 4;       
v_bp        :   INTEGER := 23;          --vertical back porch width in rows
    v_pixels    :   INTEGER := 600;     --vertical display width in rows
    v_fp        :   INTEGER := 1;           --vertical front porch width in rows
    v_pol       :   STD_LOGIC := '1');  --vertical sync pulse polarity (1 = positive, 0 = negative)
PORT(
    pixel_clk   :   IN      STD_LOGIC;  --pixel clock at frequency of VGA mode being used
    reset_n     :   IN      STD_LOGIC;      --active low asycnchronous reset
    h_sync      :   OUT STD_LOGIC;  --horiztonal sync pulse
    v_sync      :   OUT STD_LOGIC;  --vertical sync pulse
    disp_ena        :   OUT STD_LOGIC;  --display enable ('1' = display time, '0' = blanking time)
    column      :   OUT STD_LOGIC_VECTOR (10 downto 0);     --horizontal pixel coordinate
    row         :   OUT STD_LOGIC_VECTOR (10 downto 0); --vertical pixel coordinate
    n_blank     :   OUT STD_LOGIC;  --direct blacking output to DAC
    n_sync      :   OUT STD_LOGIC); --sync-on-green output to DAC
END vga_controller;

ARCHITECTURE behavior OF vga_controller IS
CONSTANT    h_period    :   INTEGER := h_pulse + h_bp + h_pixels + h_fp;  --total number of pixel clocks in a row
CONSTANT    v_period    :   INTEGER := v_pulse + v_bp + v_pixels + v_fp;  --total number of rows in column
BEGIN

BEGIN

    n_blank <= '1';  --no direct blanking
    n_sync <= '0';   --no sync on green

    PROCESS(pixel_clk, reset_n)
        VARIABLE h_count    :   STD_LOGIC RANGE 0 TO h_period - 1 := 0;  --horizontal counter (counts the columns)
        VARIABLE v_count    :   STD_LOGIC RANGE 0 TO v_period - 1 := 0;  --vertical counter (counts the rows)

    BEGIN

        IF(reset_n = '0') THEN      --reset asserted
            h_count := 0;               --reset horizontal counter
            v_count := 0;               --reset vertical counter
            h_sync <= NOT h_pol;        --deassert horizontal sync
            v_sync <= NOT v_pol;        --deassert vertical sync
            disp_ena <= '0';            --disable display
            column <= "00000000000";                --reset column pixel coordinate
            row <= "00000000000";                   --reset row pixel coordinate

        ELSIF(pixel_clk'EVENT AND pixel_clk = '1') THEN

            --counters
            IF(h_count < h_period - 1) THEN     --horizontal counter (pixels)
                h_count := h_count + 1;
            ELSE
                h_count := 0;
                IF(v_count < v_period - 1) THEN --veritcal counter (rows)
                    v_count := v_count + 1;
                ELSE
                    v_count := 0;
                END IF;
            END IF;

            --horizontal sync signal
            IF(h_count < h_pixels + h_fp OR h_count > h_pixels + h_fp + h_pulse) THEN
                h_sync <= NOT h_pol;        --deassert horiztonal sync pulse
            ELSE
                h_sync <= h_pol;            --assert horiztonal sync pulse
            END IF;

            --vertical sync signal
            IF(v_count < v_pixels + v_fp OR v_count > v_pixels + v_fp + v_pulse) THEN
                v_sync <= NOT v_pol;        --deassert vertical sync pulse
            ELSE
                v_sync <= v_pol;            --assert vertical sync pulse
            END IF;

            --set pixel coordinates
            IF(h_count < h_pixels) THEN     --horiztonal display time
                column <= h_count;          --set horiztonal pixel coordinate
            END IF;
            IF(v_count < v_pixels) THEN --vertical display time
                row <= v_count;             --set vertical pixel coordinate
            END IF;

            --set display enable output
            IF(h_count < h_pixels AND v_count < v_pixels) THEN      --display time
                disp_ena <= '1';                                                --enable display
            ELSE                                                                    --blanking time
                disp_ena <= '0';                                                --disable display
            END IF;

        END IF;
    END PROCESS;

END behavior;
3

3 Answers

0
votes

The line numbers in the error messages you provided didn't match the code fragments and you had a duplicate BEGIN for the architecture.

Go back to the original design specification:

LIBRARY ieee;
USE ieee.std_logic_1164.all;
USE ieee.numeric_std.all;

ENTITY vga_controller IS
    GENERIC(
        h_pulse     :   INTEGER := 128;     --horiztonal sync pulse width in pixels
        h_bp        :   INTEGER := 88;      --horiztonal back porch width in pixels
        h_pixels    :   INTEGER := 800;     --horiztonal display width in pixels
        h_fp        :   INTEGER := 40;      --horiztonal front porch width in pixels
        h_pol       :   STD_ULOGIC := '1';  --horizontal sync pulse polarity (1 = positive, 0 = negative)
        v_pulse     :   INTEGER := 4;       
        v_bp        :   INTEGER := 23;       --vertical back porch width in rows
        v_pixels    :   INTEGER := 600;      --vertical display width in rows
        v_fp        :   INTEGER := 1;        --vertical front porch width in rows
        v_pol       :   STD_ULOGIC := '1'    --vertical sync pulse polarity (1 = positive, 0 = negative)
    );
PORT(
        pixel_clk   :   IN  STD_LOGIC;  --pixel clock at frequency of VGA mode being used
        reset_n     :   IN  STD_LOGIC;      --active low asycnchronous reset
        h_sync      :   OUT STD_LOGIC;  --horiztonal sync pulse
        v_sync      :   OUT STD_LOGIC;  --vertical sync pulse
        disp_ena    :   OUT STD_LOGIC;  --display enable ('1' = display time, '0' = blanking time)
        column      :   OUT STD_LOGIC_VECTOR (10 downto 0);     --horizontal pixel coordinate
        row         :   OUT STD_LOGIC_VECTOR (10 downto 0); --vertical pixel coordinate
        n_blank     :   OUT STD_LOGIC;  --direct blacking output to DAC
        n_sync      :   OUT STD_LOGIC --sync-on-green output to DAC
    );
END vga_controller;

ARCHITECTURE behavior OF vga_controller IS
CONSTANT    h_period    :   INTEGER := h_pulse + h_bp + h_pixels + h_fp;  --total number of pixel clocks in a row
CONSTANT    v_period    :   INTEGER := v_pulse + v_bp + v_pixels + v_fp;  --total number of rows in column

BEGIN

    n_blank <= '1';  --no direct blanking
    n_sync <= '0';   --no sync on green

frame_counters:
    PROCESS(pixel_clk, reset_n)
        VARIABLE h_count    :   INTEGER RANGE 0 TO h_period - 1 := 0;  --horizontal counter (counts the columns)
        VARIABLE v_count    :   INTEGER RANGE 0 TO v_period - 1 := 0;  --vertical counter (counts the rows)

    BEGIN

        IF(reset_n = '0') THEN      --reset asserted
            h_count := 0;               --reset horizontal counter
            v_count := 0;               --reset vertical counter
            h_sync <= NOT h_pol;        --deassert horizontal sync
            v_sync <= NOT v_pol;        --deassert vertical sync
            disp_ena <= '0';            --disable display
            column <= "00000000000";                --reset column pixel coordinate
            row <= "00000000000";                   --reset row pixel coordinate

        ELSIF(pixel_clk'EVENT AND pixel_clk = '1') THEN

            --counters
            IF(h_count < h_period - 1) THEN     --horizontal counter (pixels)
                h_count := h_count + 1;
            ELSE
                h_count := 0;
                IF(v_count < v_period - 1) THEN --veritcal counter (rows)
                    v_count := v_count + 1;
                ELSE
                    v_count := 0;
                END IF;
            END IF;

            --horizontal sync signal
            IF(h_count < h_pixels + h_fp OR h_count > h_pixels + h_fp + h_pulse) THEN
                h_sync <= NOT h_pol;        --deassert horiztonal sync pulse
            ELSE
                h_sync <= h_pol;            --assert horiztonal sync pulse
            END IF;

            --vertical sync signal
            IF(v_count < v_pixels + v_fp OR v_count > v_pixels + v_fp + v_pulse) THEN
                v_sync <= NOT v_pol;        --deassert vertical sync pulse
            ELSE
                v_sync <= v_pol;            --assert vertical sync pulse
            END IF;

            --set pixel coordinates
            IF(h_count < h_pixels) THEN     --horiztonal display time
                column <= std_logic_vector(to_unsigned(h_count,column'LENGTH));          --set horiztonal pixel coordinate
            END IF;
            IF(v_count < v_pixels) THEN --vertical display time
                row <= std_logic_vector(to_unsigned(v_count,row'LENGTH));             --set vertical pixel coordinate
            END IF;

            --set display enable output
            IF(h_count < h_pixels AND v_count < v_pixels) THEN      --display time
                disp_ena <= '1';                                    --enable display
            ELSE                                                                  --blanking time
                disp_ena <= '0';                                                --disable display
            END IF;

        END IF;
    END PROCESS;

END behavior;

Note the changes to support integer to std_logic_vector conversion:

        --set pixel coordinates
        IF(h_count < h_pixels) THEN     --horiztonal display time
            column <= std_logic_vector(to_unsigned(h_count,column'LENGTH));  --set horiztonal pixel coordinate
        END IF;
        IF(v_count < v_pixels) THEN --vertical display time
            row <= std_logic_vector(to_unsigned(v_count,row'LENGTH));    --set vertical pixel coordinate
        END IF;

Note this is pseudo source just to analyze cleanly (and it does).

0
votes

Your problem is you are mixing integer and std_logic_vector types.

For example you assign the h_count integer to the column std_logic_vector without typecasting. Your line:

column <= h_count;

should be:

column <= std_logic_vector(to_unsigned(h_count, column'length));

this typecasts h_count to a unsigned with the same width as column, which is then cast to the std_logic_vector type. The same applies every time you convert an integer to a std_logic_vector.

To go the other way around and convert a std_logic_vector to an integer use the following example, assuming it's unsigned:

h_count <= to_integer(unsigned(column));
0
votes

If you want a vector of bits to represent a number, use the ieee.numeric_std library and then use the unsigned and/or signed types. And/or use integers. Don't use std_logic_vector to mean a number.