How can I solve "Non-static method xxx:xxx() should not be called statically in PHP 5.4?

32
votes

Currently using a large platform in PHP.

The server it's hosted on has recently been upgraded to PHP 5.4.

Since, I've received many error messages like:

[Sat May 26 19:04:41 2012] [error] PHP Strict Standards: Non-static method Config::getData() should not be called statically, assuming $this from incompatible context in /xxx/Config.inc.php on line 35

The example method is defined as (note the lack of 'static' keyword):

function &getData() {
            $configData =& Registry::get('configData', true, null);

    if ($configData === null) {
        // Load configuration data only once per request, implicitly
        // sets config data by ref in the registry.
        $configData = Config::reloadData();
    }

    return $configData;
}

This has no caused a problem before, and I assume the error messages (which cause the application to crash) may be related to the recent upgrade to PHP5.4.

Is there a PHP setting I can modify to 'ignore' the lack of static keyword?

4
phpstatic-methods
Create an instance of Config and call getData() from it – Musa
Could you include a sample of the contents of &getData()? Specifically, what exactly is being returned and how. – Ayman Safadi
Added the contents of &getData() to the original question -- I must emphasise though, that this error has only been raised since the upgrade to 5.4, so I'm confident the logic is fine – kaese
possible duplicate of Error message Strict standards: Non-static method should not be called statically in php – Michel Ayres

4 Answers

44
votes

You can either remove E_STRICT from error_reporting(), or you can simply make your method static, if you need to call it statically. As far as I know, there is no (strict) way to have a method that can be invoked both as static and non-static method. Also, which is more annoying, you cannot have two methods with the same name, one being static and the other non-static.

31
votes

Disabling the alert message is not a way to solve the problem. Despite the PHP core is continue to work it makes a dangerous assumptions and actions.

Never ignore the error where PHP should make an assumptions of something!!!!

If the class organized as a singleton you can always use function getInstance() and then use getData()

Likse: 

$classObj = MyClass::getInstance();
$classObj->getData();

If the class is not a singleton, use 

 $classObj = new MyClass();
 $classObj->getData();
10
votes

I don't suggest you just hidding the stricts errors on your project. Intead, you should turn your method to static or try to creat a new instance of the object:

$var = new YourClass();
$var->method();

You can also use the new way to do the same since PHP 5.4:

(new YourClass)->method();

I hope it helps you!

-4
votes

I solved this with one code line, as follow: In file index.php, at your template root, after this code line:

defined( '_JEXEC' ) or die( 'Restricted access' );

paste this line: ini_set ('display_errors', 'Off');

Don't worry, be happy...

posted by Jenio.